You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by phrocker <gi...@git.apache.org> on 2018/09/02 19:44:37 UTC
[GitHub] nifi-minifi-cpp pull request #394: MINIFICPP-595: Provide basic support for ...
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/394
MINIFICPP-595: Provide basic support for windows.
MINIFICPP-32: Add windows event log reader
MINIFICPP-596: Build core and libminifi artifacts. Must abstract
features that are operating system dependent, such as uuid
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp windows
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/394.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #394
----
commit 8157d27d7425d476d420c14112ac791dfe751950
Author: Marc Parisi <ph...@...>
Date: 2018-08-02T14:36:20Z
MINIFICPP-595: Provide basic support for windows.
MINIFICPP-32: Add windows event log reader
MINIFICPP-596: Build core and libminifi artifacts. Must abstract
features that are operating system dependent, such as uuid
----
---
[GitHub] nifi-minifi-cpp pull request #394: MINIFICPP-595: Provide basic support for ...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/394#discussion_r217873438
--- Diff: LICENSE ---
@@ -1427,3 +1451,183 @@ This product bundles 'bsdiff' which is available under a "2-clause BSD" license.
STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
POSSIBILITY OF SUCH DAMAGE.
+
+ This product bundles 'Simple-Windows-Posix-Semaphore' which is available under an Apache v2 License.
--- End diff --
As this is ALv2 it shouldn't be needed in the LICENSE. There does not appear to be a NOTICE which would have to get incorporated.
---
[GitHub] nifi-minifi-cpp pull request #394: MINIFICPP-595: Provide basic support for ...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/394#discussion_r218532216
--- Diff: LICENSE ---
@@ -1427,3 +1451,183 @@ This product bundles 'bsdiff' which is available under a "2-clause BSD" license.
STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
POSSIBILITY OF SUCH DAMAGE.
+
+ This product bundles 'Simple-Windows-Posix-Semaphore' which is available under an Apache v2 License.
--- End diff --
I always felt this was good hygiene as a practice. Further I always thought that Category A licenses needed to adhere to the attribution portion of the aforementioned license. 4.d of http://apache.org/licenses/LICENSE-2.0 led me to believe this is a smart inclusion. I assume there is other language that makes this recursive attribution assumed?
---
[GitHub] nifi-minifi-cpp issue #394: MINIFICPP-595: Provide basic support for windows...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/394
Had some issues on a VM environment with build but seems to be just something on that system's configuration. A clean Windows 10 VM as well as a baremetal Win 10 built and worked without issue. Verified some simple flows and expected operation. Will get these items merged.
---
[GitHub] nifi-minifi-cpp pull request #394: MINIFICPP-595: Provide basic support for ...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/394#discussion_r217873295
--- Diff: CMakeSettings.json ---
@@ -0,0 +1,146 @@
+{
+ // See https://go.microsoft.com//fwlink//?linkid=834763 for more information about this file.
+ "configurations": [
+ {
+ "name": "x86-Debug",
--- End diff --
Should we remove these other configurations (those besides x64-Debug) until they are functional?
---
[GitHub] nifi-minifi-cpp pull request #394: MINIFICPP-595: Provide basic support for ...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/394#discussion_r218535623
--- Diff: LICENSE ---
@@ -1427,3 +1451,183 @@ This product bundles 'bsdiff' which is available under a "2-clause BSD" license.
STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
POSSIBILITY OF SUCH DAMAGE.
+
+ This product bundles 'Simple-Windows-Posix-Semaphore' which is available under an Apache v2 License.
--- End diff --
@apiri I added this very early on into the branch and thought I only had the first line ( also coincidentally only saw this in your comment ). Yes, totally agree that all of that text below the project and version is completely unnecessary. thanks!
---
[GitHub] nifi-minifi-cpp issue #394: MINIFICPP-595: Provide basic support for windows...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/394
reviewing
---
[GitHub] nifi-minifi-cpp pull request #394: MINIFICPP-595: Provide basic support for ...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/394#discussion_r218533580
--- Diff: LICENSE ---
@@ -1427,3 +1451,183 @@ This product bundles 'bsdiff' which is available under a "2-clause BSD" license.
STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
POSSIBILITY OF SUCH DAMAGE.
+
+ This product bundles 'Simple-Windows-Posix-Semaphore' which is available under an Apache v2 License.
--- End diff --
The guidance from ASF is here http://www.apache.org/dev/licensing-howto.html#alv2-dep. To your point, and in light of the ASF guidance, I believe we could just list the project and its version omitting the full license text?
---
[GitHub] nifi-minifi-cpp issue #394: MINIFICPP-595: Provide basic support for windows...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/394
@apiri it is not anticipated that OpenSSL be installed for this release. Will check. Thanks!
---
[GitHub] nifi-minifi-cpp pull request #394: MINIFICPP-595: Provide basic support for ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/394
---