You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/29 13:20:49 UTC

[GitHub] [apisix] imjoey commented on a change in pull request #4708: chore: add sudo privilege for make install command at installing luarocks

imjoey commented on a change in pull request #4708:
URL: https://github.com/apache/apisix/pull/4708#discussion_r679143704



##########
File path: utils/linux-install-luarocks.sh
##########
@@ -40,7 +40,7 @@ fi
 
 make build > build.log 2>&1 || (cat build.log && exit 1)
 msg="rerun this script with 'sudo' if you failed to make install because of privilege problem."

Review comment:
       I think yes if everything is as expected. We could safely remove this prompt if it's only for `make install`. What do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org