You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "Steve Lawrence (Jira)" <ji...@apache.org> on 2021/02/18 21:24:00 UTC
[jira] [Updated] (DAFFODIL-2331) Remove argType parameter from
FNZeroArgExpr and derived classes
[ https://issues.apache.org/jira/browse/DAFFODIL-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Lawrence updated DAFFODIL-2331:
-------------------------------------
Priority: Minor (was: Major)
> Remove argType parameter from FNZeroArgExpr and derived classes
> ---------------------------------------------------------------
>
> Key: DAFFODIL-2331
> URL: https://issues.apache.org/jira/browse/DAFFODIL-2331
> Project: Daffodil
> Issue Type: Improvement
> Components: Clean Ups
> Reporter: John Interrante
> Priority: Minor
>
> Expression.scala uses FNZeroArgExpr to implement fn:local-name, fn:namespace-uri, dfdlx:outputTypeCalcNextSibling, dfdlx:repTypeValue, and dfdlx:logicalTypeValue functions. It has to pass NodeInfo.XXX for the argType parameter, even though the argType parameter shouldn't be needed if there are zero arguments. Should we remove this parameter? It looks like argType is used only in targetTypeForSubexpression, which should never be called in FNZeroArgExpr since there are zero arguments.
> If we remove the argType parameter, we also shouldn't need to pass argType to the constructor for FNNamespaceURI0 and similar classes in FNFunctions.scala.
> People who can answer questions about this issue are Steve Lawrence and myself (although Steve can answer questions better).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)