[GitHub] [maven-plugin-tools] michael-o commented on a change in pull request #73: [MPLUGIN-394] Respect input encoding

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #73:
URL: https://github.com/apache/maven-plugin-tools/pull/73#discussion_r815426373



##########
File path: maven-plugin-plugin/src/it/mplugin-394_report-encoding/invoker.properties
##########
@@ -0,0 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+# 
+#   http://www.apache.org/licenses/LICENSE-2.0
+# 
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+invoker.goals = -Dfile.encoding=CP1252 plugin:report

Review comment:
       I know and am I bit late, but this is brittle and wrong. This system property shall only be set, at most, at JVM startup time. I highly doubt that Invoker does that.
   Read JEP 400:
   
       Developers sometimes attempt to configure the default charset by setting the system property
       file.encoding on the   command line (i.e., java -Dfile.encoding=...), but this has never been supported.
       Furthermore, attempting to set the property programmatically (i.e., System.setProperty(...)) after the
       Java runtime has started does not work.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org