[GitHub] [helix] alirezazamani commented on a change in pull request #1548: Fix targeted job quota calculation for given up tasks

[GitBox <gi...@apache.org>]

alirezazamani commented on a change in pull request #1548:
URL: https://github.com/apache/helix/pull/1548#discussion_r529010453



##########
File path: helix-core/src/main/java/org/apache/helix/task/AbstractTaskDispatcher.java
##########
@@ -838,7 +839,7 @@ private static void addCompletedTasks(Set<Integer> set, JobContext ctx, Iterable
    */
   private boolean isTaskNotInTerminalState(TaskPartitionState state) {

Review comment:
       We need to note that this no design. This is a bug which is introduced before and is impacting production result. I tried differently but I believe this is the best way.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org