You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/10/05 17:14:46 UTC
[GitHub] [tvm] kparzysz-quic opened a new pull request #9201: [cpptest] Get the full path to gtest_main library
kparzysz-quic opened a new pull request #9201:
URL: https://github.com/apache/tvm/pull/9201
The gtest framework requires two libraries: `gtest` and `gtest_main`. The former is found via `find_library`, which returns the full path to it. The latter is only added to target_link_libraries as `gtest_main`. Adding `gtest_main` to target_link_libraries causes cmake to emit `-lgtest_main`, but the path to it is not provided (there is no `-L` flag for it), and the link step can fail.
As a fix, use `find_library` to get the full path to `gtest_main` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kparzysz-quic closed pull request #9201: [cpptest] Get the full path to gtest_main library
Posted by GitBox <gi...@apache.org>.
kparzysz-quic closed pull request #9201:
URL: https://github.com/apache/tvm/pull/9201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on pull request #9201: [cpptest] Get the full path to gtest_main library
Posted by GitBox <gi...@apache.org>.
tkonolige commented on pull request #9201:
URL: https://github.com/apache/tvm/pull/9201#issuecomment-934894237
It seems like this problem could be fixed by using `find_package(GTest)` (https://cmake.org/cmake/help/v3.8/module/FindGTest.html) instead of rolling our own. Is there a reason not to do this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kparzysz-quic commented on pull request #9201: [cpptest] Get the full path to gtest_main library
Posted by GitBox <gi...@apache.org>.
kparzysz-quic commented on pull request #9201:
URL: https://github.com/apache/tvm/pull/9201#issuecomment-936287757
Replaced by https://github.com/apache/tvm/pull/9208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kparzysz-quic commented on pull request #9201: [cpptest] Get the full path to gtest_main library
Posted by GitBox <gi...@apache.org>.
kparzysz-quic commented on pull request #9201:
URL: https://github.com/apache/tvm/pull/9201#issuecomment-935203585
> It seems like this problem could be fixed by using `find_package(GTest)` (https://cmake.org/cmake/help/v3.8/module/FindGTest.html) instead of rolling our own. Is there a reason not to do this?
I didn't know about it. I will have the changes ready soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org