[GitHub] [iceberg] ludlows commented on pull request #6760: Spark 3.3: use a deterministic where condition to make rewrite_data_files…

["ludlows (via GitHub)" <gi...@apache.org>]

ludlows commented on PR #6760:
URL: https://github.com/apache/iceberg/pull/6760#issuecomment-1454951574

   Hi @szehon-ho ,
   
   I added a test case for this PR. you may comment some lines of code to reproduce the bug in file [RewriteDataFilesProcedure.java](https://github.com/ludlows/iceberg/blob/rewritr_data_file-exit-where-false/spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteDataFilesProcedure.java)  :
   ```java
   // if (where != null && SparkExpressionConverter.checkWhereAlwaysFalse(spark(), quotedFullIdentifier, where)) {
   //            RewriteDataFiles.Result result = new BaseRewriteDataFilesResult(Lists.newArrayList());
   //            return toOutputRows(result);
   // }
   ``` 
   let me know if you have any questions. 
   thanks. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org