You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Costin Manolache <cm...@yahoo.com> on 2003/01/08 19:13:58 UTC
Log names ( for c-l ) was: Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/listener CommonsLoggingListener.java
Erik ( and others ):
What about using the task name and for the channel names :
Something like:
ant.tasks.TASK_NAME.TARGET_NAME ( ant.tasks.copy.init instead of
org.apache.tools.ant.taskdefs.Copy.init )
Also - what about adding the project name - so you can toggle debugging ( or
silence ) for a task globally, only in a specific target, or in a specific
target in a specific project.
It's easier to type...
Probably same thing for target and project - but that won't be used too
much.
Costin
Erik Hatcher wrote:
> On Tuesday, January 7, 2003, at 11:35 PM, costin@apache.org wrote:
>> costin 2003/01/07 20:35:22
>
> [...]
>
>> +import org.apache.tools.ant.*;
>
> Our conventions are to expand out all imports, rather than using .*
>
>> +public class CommonsLoggingListener implements BuildListener,
>> BuildLogger {
>
> This could be shortened to a single implement of BuildLogger, since
> that in turn implements BuildListener, FYI.
>
> Glad to see this listener/logger getting some interest!
>
> Erik
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: Log names ( for c-l ) was: Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/listener CommonsLoggingListener.java
Posted by Erik Hatcher <ja...@ehatchersolutions.com>.
Costin - it would probably be a good idea to keep the naming
conventions the same between the raw Log4jListener and the
CommonsLoggingListener - although Log4JListener has been out for much
longer and perhaps folks are relying on the category names used by it
and would be upset for it changing?
Thoughts?
It would be more awkward to have them be different between the two, in
case someone wants to bump up to the CommonsLoggingListener - or so it
seems?
Either way, its no big deal to me since I don't really use either on a
regular basis and the category names are easily changed if we do happen
to affect them for someone.
Erik
On Thursday, January 9, 2003, at 01:59 AM, Stefan Bodewig wrote:
> On Wed, 8 Jan 2003, Erik Hatcher <ja...@ehatchersolutions.com>
> wrote:
>
>> Keep in mind that your previous change, and your proposed changes
>> break backwards compatibility in case anyone had already set up
>> filters for Commons Logging, but thats not very likely to be an
>> issue anyone would complain about.
>
> I agree on both points (it breaks bc and it is no real problem), but
> please document it in WHATSNEW.
>
> Oh, no opinion on the names here.
>
> Stefan
>
> --
> To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> For additional commands, e-mail:
> <ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: Log names ( for c-l ) was: Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/listener CommonsLoggingListener.java
Posted by Stefan Bodewig <bo...@apache.org>.
On Wed, 8 Jan 2003, Erik Hatcher <ja...@ehatchersolutions.com>
wrote:
> Keep in mind that your previous change, and your proposed changes
> break backwards compatibility in case anyone had already set up
> filters for Commons Logging, but thats not very likely to be an
> issue anyone would complain about.
I agree on both points (it breaks bc and it is no real problem), but
please document it in WHATSNEW.
Oh, no opinion on the names here.
Stefan
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: Log names ( for c-l ) was: Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/listener CommonsLoggingListener.java
Posted by Erik Hatcher <ja...@ehatchersolutions.com>.
Sounds fine to me. I personally rarely use any kind of
logging/listener for my builds, but its definitely handy when needed
like in the case of using Ant within Tomcat.
Keep in mind that your previous change, and your proposed changes break
backwards compatibility in case anyone had already set up filters for
Commons Logging, but thats not very likely to be an issue anyone would
complain about.
Erik
On Wednesday, January 8, 2003, at 01:13 PM, Costin Manolache wrote:
> Erik ( and others ):
>
> What about using the task name and for the channel names :
>
> Something like:
>
> ant.tasks.TASK_NAME.TARGET_NAME ( ant.tasks.copy.init instead of
> org.apache.tools.ant.taskdefs.Copy.init )
>
> Also - what about adding the project name - so you can toggle
> debugging ( or
> silence ) for a task globally, only in a specific target, or in a
> specific
> target in a specific project.
>
> It's easier to type...
> Probably same thing for target and project - but that won't be used too
> much.
>
> Costin
>
>
> Erik Hatcher wrote:
>
>> On Tuesday, January 7, 2003, at 11:35 PM, costin@apache.org wrote:
>>> costin 2003/01/07 20:35:22
>>
>> [...]
>>
>>> +import org.apache.tools.ant.*;
>>
>> Our conventions are to expand out all imports, rather than using .*
>>
>>> +public class CommonsLoggingListener implements BuildListener,
>>> BuildLogger {
>>
>> This could be shortened to a single implement of BuildLogger, since
>> that in turn implements BuildListener, FYI.
>>
>> Glad to see this listener/logger getting some interest!
>>
>> Erik
>
>
>
> --
> To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> For additional commands, e-mail:
> <ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>