You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ganeshmurthy <gi...@git.apache.org> on 2018/02/28 20:29:16 UTC
[GitHub] qpid-dispatch pull request #263: DISPATCH-933 - Created new RouterStats enti...
GitHub user ganeshmurthy opened a pull request:
https://github.com/apache/qpid-dispatch/pull/263
DISPATCH-933 - Created new RouterStats entity. Moved some attributes …
…from Router entity to RouterStats. Router entity is not handled by the Python management agent and the RouterStats entity is handled by the C management agent
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-933
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/263.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #263
----
commit 14339b3339f5ebbd57eb6e5e55204b16771b969f
Author: Ganesh Murthy <gm...@...>
Date: 2018-02-28T18:58:10Z
DISPATCH-933 - Created new RouterStats entity. Moved some attributes from Router entity to RouterStats. Router entity is not handled by the Python management agent and the RouterStats entity is handled by the C management agent
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #263: DISPATCH-933 - Created new RouterStats enti...
Posted by bhardesty <gi...@git.apache.org>.
Github user bhardesty commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/263#discussion_r172300792
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -431,37 +431,100 @@
"description": "Time in seconds after which link state is declared stale if no RA is received.",
"create": true
},
- "addrCount": {
- "type": "integer",
- "description":"Number of addresses known to the router.",
- "graph": true
- },
- "linkCount": {
+ "workerThreads": {
"type": "integer",
- "description":"Number of links attached to the router node.",
- "graph": true
+ "default": 4,
+ "description": "The number of threads that will be created to process message traffic and other application work (timers, non-amqp file descriptors, etc.) .",
+ "create": true
},
- "nodeCount": {
- "type": "integer",
- "description":"Number of known peer router nodes.",
- "graph": true
+ "debugDump": {
+ "type": "path",
+ "description": "A file to dump debugging information that can't be logged normally.",
--- End diff --
What does it it mean that this information can't be logged normally - just that it isn't captured by one of the logging modules?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #263: DISPATCH-933 - Created new RouterStats enti...
Posted by ganeshmurthy <gi...@git.apache.org>.
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/263#discussion_r172309974
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -431,37 +431,100 @@
"description": "Time in seconds after which link state is declared stale if no RA is received.",
"create": true
},
- "addrCount": {
- "type": "integer",
- "description":"Number of addresses known to the router.",
- "graph": true
- },
- "linkCount": {
+ "workerThreads": {
"type": "integer",
- "description":"Number of links attached to the router node.",
- "graph": true
+ "default": 4,
+ "description": "The number of threads that will be created to process message traffic and other application work (timers, non-amqp file descriptors, etc.) .",
+ "create": true
},
- "nodeCount": {
- "type": "integer",
- "description":"Number of known peer router nodes.",
- "graph": true
+ "debugDump": {
+ "type": "path",
+ "description": "A file to dump debugging information that can't be logged normally.",
--- End diff --
debug dumps are the copies of the contents of the computer's memory. When the router crashes, it will dump all its memory content into the debug dump file. which is stored in the hard disk. This file is useful for technical support people/programmers.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #263: DISPATCH-933 - Created new RouterStats enti...
Posted by ganeshmurthy <gi...@git.apache.org>.
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/263#discussion_r172352976
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -431,37 +431,100 @@
"description": "Time in seconds after which link state is declared stale if no RA is received.",
"create": true
},
- "addrCount": {
- "type": "integer",
- "description":"Number of addresses known to the router.",
- "graph": true
- },
- "linkCount": {
+ "workerThreads": {
"type": "integer",
- "description":"Number of links attached to the router node.",
- "graph": true
+ "default": 4,
+ "description": "The number of threads that will be created to process message traffic and other application work (timers, non-amqp file descriptors, etc.) .",
+ "create": true
},
- "nodeCount": {
- "type": "integer",
- "description":"Number of known peer router nodes.",
- "graph": true
+ "debugDump": {
+ "type": "path",
+ "description": "A file to dump debugging information that can't be logged normally.",
--- End diff --
I was wrong about the debug dump file. It is not a process dump. It seems to be used only in alloc_pool.c
This is a file to which debug information is written when the logger has not yet started or has already been shutdown. When the loggers are not available, the router writes to this file.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #263: DISPATCH-933 - Created new RouterStats enti...
Posted by bhardesty <gi...@git.apache.org>.
Github user bhardesty commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/263#discussion_r172520473
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -431,37 +431,100 @@
"description": "Time in seconds after which link state is declared stale if no RA is received.",
"create": true
},
- "addrCount": {
- "type": "integer",
- "description":"Number of addresses known to the router.",
- "graph": true
- },
- "linkCount": {
+ "workerThreads": {
"type": "integer",
- "description":"Number of links attached to the router node.",
- "graph": true
+ "default": 4,
+ "description": "The number of threads that will be created to process message traffic and other application work (timers, non-amqp file descriptors, etc.) .",
+ "create": true
},
- "nodeCount": {
- "type": "integer",
- "description":"Number of known peer router nodes.",
- "graph": true
+ "debugDump": {
+ "type": "path",
+ "description": "A file to dump debugging information that can't be logged normally.",
--- End diff --
In that case, how about this:
The absolute path to the location for the debug dump file. The router writes debug-level information to this file if the logger is not available.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #263: DISPATCH-933 - Created new RouterStats enti...
Posted by ganeshmurthy <gi...@git.apache.org>.
Github user ganeshmurthy closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/263
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #263: DISPATCH-933 - Created new RouterStats enti...
Posted by bhardesty <gi...@git.apache.org>.
Github user bhardesty commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/263#discussion_r172346629
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -431,37 +431,100 @@
"description": "Time in seconds after which link state is declared stale if no RA is received.",
"create": true
},
- "addrCount": {
- "type": "integer",
- "description":"Number of addresses known to the router.",
- "graph": true
- },
- "linkCount": {
+ "workerThreads": {
"type": "integer",
- "description":"Number of links attached to the router node.",
- "graph": true
+ "default": 4,
+ "description": "The number of threads that will be created to process message traffic and other application work (timers, non-amqp file descriptors, etc.) .",
+ "create": true
},
- "nodeCount": {
- "type": "integer",
- "description":"Number of known peer router nodes.",
- "graph": true
+ "debugDump": {
+ "type": "path",
+ "description": "A file to dump debugging information that can't be logged normally.",
--- End diff --
OK, so essentially a core dump. I didn't get that at first. Anyways, I'd suggest the following description (assuming of course that debugDump requires the absolute path, and that the path is to a directory, not the name of the actual debug dump file):
The absolute path to the location for debug dump files. If the router crashes, a debug dump file is created in this directory to assist in troubleshooting the problem.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org