You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/01/26 21:44:13 UTC

[GitHub] [incubator-yunikorn-k8shim] yangwwei opened a new pull request #223: [YUNIKORN-512] Remove redundant log from placeholder manager

yangwwei opened a new pull request #223:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/223


   - Remove "cleanup orphan pods" log that gets printed every few second
   - Update the dependency to the latest core


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #223: [YUNIKORN-512] Remove redundant log from placeholder manager

Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #223:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/223#issuecomment-768058490


   @kingamarton could you please help to review? Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #223: [YUNIKORN-512] Remove redundant log from placeholder manager

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #223:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/223#issuecomment-767956790


   # [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/223?src=pr&el=h1) Report
   > Merging [#223](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/223?src=pr&el=desc) (ecffe16) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/12ecf1165635957e25018fb4faab3b9734e1c10d?el=desc) (12ecf11) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/223/graphs/tree.svg?width=650&height=150&src=pr&token=LZImIuvleR)](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/223?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #223      +/-   ##
   ==========================================
   - Coverage   59.72%   59.71%   -0.02%     
   ==========================================
     Files          35       35              
     Lines        3136     3135       -1     
   ==========================================
   - Hits         1873     1872       -1     
     Misses       1181     1181              
     Partials       82       82              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/223?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/223/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `77.61% <ø> (-0.33%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/223?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/223?src=pr&el=footer). Last update [12ecf11...ecffe16](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/223?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] kingamarton closed pull request #223: [YUNIKORN-512] Remove redundant log from placeholder manager

Posted by GitBox <gi...@apache.org>.
kingamarton closed pull request #223:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/223


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org