You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/09/27 02:21:00 UTC

[jira] [Commented] (SOLR-16967) ConfigSetService.checkConfigExists should not depend on solrconfig.xml existing

    [ https://issues.apache.org/jira/browse/SOLR-16967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769402#comment-17769402 ] 

ASF subversion and git services commented on SOLR-16967:
--------------------------------------------------------

Commit 4c80cc2ef9e50915fb7aaa6e9cfe042a27d2c44d in solr's branch refs/heads/main from David Smiley
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=4c80cc2ef9e ]

SOLR-16967: ConfigSet: shouldn't require solrconfig.xml (#1900)

ConfigSetService.checkConfigExists() should not require solrconfig.xml to exist; the parent directory's existence is fine.  Users may choose for their config to be a different name, after all.

> ConfigSetService.checkConfigExists should not depend on solrconfig.xml existing
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-16967
>                 URL: https://issues.apache.org/jira/browse/SOLR-16967
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> ConfigSetService.checkConfigExists is defined rather generally; it makes no mention of solrconfig.xml.  Yet both implementations (FileSystem & Zk) look for solrconfig.xml specifically.  They need not do this, and it's presumptuous to assume this specific file since a CoreDescriptor can refer to a different/custom file.  So this change is to only look for the directory.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org