[GitHub] [orc] wgtmac commented on pull request #1317: ORC-1314: [C++] Remove macros defined before C++11

[GitBox <gi...@apache.org>]

wgtmac commented on PR #1317:
URL: https://github.com/apache/orc/pull/1317#issuecomment-1321730420

   > Does this pass our Docker tests?
   > 
   > ```
   > $ cd docker
   > $ ./run-all.sh apache main
   > ```
   
   Thanks for the review! @dongjoon-hyun 
   
   I found that the centos7 docker image is failing with an old gcc version:
   
   ```
   Cloning into 'orc'...
   -- The C compiler identification is GNU 4.8.5
   -- The CXX compiler identification is GNU 4.8.5
   -- Check for working C compiler: /usr/bin/cc
   -- Check for working C compiler: /usr/bin/cc -- works
   -- Detecting C compiler ABI info
   -- Detecting C compiler ABI info - done
   -- Detecting C compile features
   -- Detecting C compile features - done
   -- Check for working CXX compiler: /usr/bin/c++
   -- Check for working CXX compiler: /usr/bin/c++ -- works
   -- Detecting CXX compiler ABI info
   -- Detecting CXX compiler ABI info - done
   -- Detecting CXX compile features
   -- Detecting CXX compile features - done
   -- No build type selected, default to ReleaseWithDebugInfo
   -- compiler GNU version 4.8.5
   -- Configuring incomplete, errors occurred!
   See also "/root/orc/build/CMakeFiles/CMakeOutput.log".
   CMake Error at CMakeLists.txt:134 (message):
     A c++17-compliant compiler is required, please use at least GCC 5
   ```
   
   We may need fix the docker images before proceeding.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org