[GitHub] [helix] qqu0127 commented on a change in pull request #2011: WIP -- Attempt to fix TestDropResourceMetricsReset

[GitBox <gi...@apache.org>]

qqu0127 commented on a change in pull request #2011:
URL: https://github.com/apache/helix/pull/2011#discussion_r840992401



##########
File path: helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -552,7 +552,7 @@ private static PipelineRegistry createDefaultRegistry(String pipelineName) {
       autoExitMaintenancePipeline.addStage(new MaintenanceRecoveryStage());
 
       registry.register(ClusterEventType.IdealStateChange, dataRefresh, dataPreprocess,
-          rebalancePipeline);
+          externalViewPipeline, rebalancePipeline);

Review comment:
       Right now I doubt the non-deterministic part, like, what if we have `setupTool.dropResourceFromCluster` long enough after `participant.syncStop()`, will the test still pass occasionally? I documented something in description regarding ExternalViewComputeStage.
   This is a good topic for discussion, we need to review and define the expected behavior. If the test is describing the right behavior, then it's a bug in code we need to fix.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org