[jira] [Commented] (FLINK-8094) Support other types for ExistingField rowtime extractor

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532831#comment-16532831 ] 

ASF GitHub Bot commented on FLINK-8094:
---------------------------------------

GitHub user HeartSaVioR opened a pull request:

    https://github.com/apache/flink/pull/6253

    [FLINK-8094][Table API & SQL] Support other types for ExistingField rowtime extractor

    ## What is the purpose of the change
    
    This patch proposes new rowtime extractor which is improved version of ExistingField,
    handles ISO dateformatted String type as well as Long and Timestamp types.
    
    ## Brief change log
    
    * introduce IsoDateStringAwareExistingField class to provide improved version of ExistingField
      * handles ISO dateformatted String type as well as Long and Timestamp types.
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
    - Manually verified the change by applying to TableSource which has ISO dateformatted STRING as rowtime field's type and confirmed watermark working correctly.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes)
      - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HeartSaVioR/flink FLINK-8094

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6253
    
----
commit 75426f7c2adc18367eab961ce76612b31c837eb0
Author: Jungtaek Lim <ka...@...>
Date:   2018-07-04T14:24:29Z

    [FLINK-8094][Table API & SQL] Support other types for ExistingField rowtime extractor
    
    This patch proposes new rowtime extractor which is improved version of ExistingField,
    handles ISO dateformatted String type as well as Long and Timestamp types.

----


> Support other types for ExistingField rowtime extractor
> -------------------------------------------------------
>
>                 Key: FLINK-8094
>                 URL: https://issues.apache.org/jira/browse/FLINK-8094
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API &amp; SQL
>    Affects Versions: 1.4.0, 1.5.0
>            Reporter: Xingcan Cui
>            Priority: Major
>              Labels: pull-request-available
>
> Currently, the {{ExistingField}} rowtime extractor only supports {{Long}} and {{Timestamp}} fields. To enable other data types (e.g., {{String}}), we can provide some system extraction functions and allow users to pass some parameters via the constructor of {{ExistingField}}. There's [a simple demo|https://github.com/xccui/flink/commit/afcc5f1a0ad92db08294199e61be5df72c1514f8] which enables the {{String}} type rowtime by adding a UDF {{str2EventTime}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)