You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/04 07:41:14 UTC

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4021: Boot into hardware setup menu on Vmware

DaanHoogland commented on a change in pull request #4021:
URL: https://github.com/apache/cloudstack/pull/4021#discussion_r435053946



##########
File path: api/src/main/java/com/cloud/agent/api/to/VirtualMachineTO.java
##########
@@ -65,6 +65,7 @@
     String uuid;
     String bootType;
     String bootMode;
+    boolean enterHardwareSetup;

Review comment:
       in hindsite this name should have been something like "bootIntoFirmware". many names have passed the catwalk. on resource level it is called enterHardwareSetup on API it is bootIntoSetup. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org