You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by TanaseButcaru <gi...@git.apache.org> on 2016/02/15 20:01:59 UTC
[GitHub] cordova-plugin-camera pull request: separate FILE_URI and NATIVE_U...
GitHub user TanaseButcaru opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/169
separate FILE_URI and NATIVE_URI / take in account user defined destType
Right now, on Android, ``FILE_URI`` and ``NATIVE_URI`` returns the path with ``content://`` scheme, excepting the case when the image has been modified.
These changes take in account what is the user defined ``destType`` and returns the path as requested.
I know there were discussions on JIRA ([CB-9548](https://issues.apache.org/jira/browse/CB-9548)) about how ``FILE_URI`` and ``NATIVE_URI`` should look, but I came to think that it should be like this:
* FILE_URI should return the ``file://`` scheme;
* NATIVE_URI should return the ``content://`` scheme;
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TanaseButcaru/cordova-plugin-camera-unofficial fileuri-nativeuri
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/169.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #169
----
commit 5e496f143c9b980ece203141204452bbf9178702
Author: TanaseButcaru <co...@butcaru.com>
Date: 2016-02-15T02:04:08Z
separate FILE_URI and NATIVE_URI
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #169: separate FILE_URI and NATIVE_URI / take in...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/169
Closing PR, since it's conflicting and we're now using File Providers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #169: separate FILE_URI and NATIVE_URI / take in...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/169
The web doesn't know what content URIs are, so we should never return them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request #169: separate FILE_URI and NATIVE_URI / ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/169
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: separate FILE_URI and NATIVE_U...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/169#issuecomment-187384251
I'm not sure we ever got consensus on the mailing list about what the desired behavior should be. I'm not saying this is wrong, I'm just not sure where we landed on this particular issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org