You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/03 09:16:12 UTC

[GitHub] [spark] beliefer commented on a change in pull request #33889: [SPARK-36632][SQL] DivideYMInterval and DivideDTInterval should throw the same exception when divide by zero.

beliefer commented on a change in pull request #33889:
URL: https://github.com/apache/spark/pull/33889#discussion_r701736293



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala
##########
@@ -641,6 +649,11 @@ case class DivideYMInterval(
       val javaType = CodeGenerator.javaType(dataType)
       val months = left.genCode(ctx)
       val num = right.genCode(ctx)
+      val checkDivideByZero =

Review comment:
       Yes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org