You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by bso-intel <gi...@git.apache.org> on 2016/02/22 00:30:18 UTC
[GitHub] cordova-ios pull request: CB-10659 changed project name to fix the...
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-ios/pull/195
CB-10659 changed project name to fix the platform add failure
The project name "Hello Cordova" does not match with template project "HelloCordova", and it causes failure when finding the <project_name>.xcodeproj file as a part of installing plugin files.
By matching the project names with the template, platform add worked fine.
After the fix is applied, the platforms/ios directory contains the following files:
```
[ios] ls
CordovaLib cordova www
HelloCordova ios.json
HelloCordova.xcodeproj platform_www
```
The platform add ios worked fine now.
```
[t6.0.1] cordova platform add ~/cordova/bso-cordova-ios
Adding ios project...
iOS project created with cordova-ios@4.1.0-dev
Installing "cordova-plugin-device" for ios
Discovered plugin "cordova-plugin-whitelist" in config.xml. Installing to the project
Fetching plugin "cordova-plugin-whitelist@1" via npm
Installing "cordova-plugin-whitelist" for ios
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bso-intel/cordova-ios CB-10659
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/195.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #195
----
commit be3e2ea6ab69f890469e142f68457da056336cbb
Author: Byoungro So <by...@intel.com>
Date: 2016-02-21T23:18:25Z
CB-10659 changed project name to fix the platform add failure
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-10659 changed project name to fix the...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/195
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-10659 changed project name to fix the...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-ios/pull/195#issuecomment-187367905
LGTM! I tested this and it works!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-10659 changed project name to fix the...
Posted by bso-intel <gi...@git.apache.org>.
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-ios/pull/195#issuecomment-189121892
Hi @nikhilkh
Thanks for testing.
Could you merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org