You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by sa...@apache.org on 2017/07/27 15:29:02 UTC

[2/3] lucene-solr:branch_7x: SOLR-10926: Increase the odds of randomly choosing point fields in our SolrTestCaseJ4 numeric type randomization

SOLR-10926: Increase the odds of randomly choosing point fields in our SolrTestCaseJ4 numeric type randomization


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/48be8ec1
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/48be8ec1
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/48be8ec1

Branch: refs/heads/branch_7x
Commit: 48be8ec1def8fcb843e0b3794936a036e0ca7eb6
Parents: 494a254
Author: Steve Rowe <sa...@apache.org>
Authored: Thu Jul 27 11:28:26 2017 -0400
Committer: Steve Rowe <sa...@apache.org>
Committed: Thu Jul 27 11:28:45 2017 -0400

----------------------------------------------------------------------
 solr/CHANGES.txt                                                 | 3 +++
 solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/48be8ec1/solr/CHANGES.txt
----------------------------------------------------------------------
diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
index a63598c..bc74b25 100644
--- a/solr/CHANGES.txt
+++ b/solr/CHANGES.txt
@@ -550,6 +550,9 @@ Other Changes
 * SOLR-11056: Add random range query test that compares results across Trie*, *Point and DocValue-only fields
   (Tomás Fernández Löbbe)
 
+* SOLR-10926: Increase the odds of randomly choosing point fields in our SolrTestCaseJ4 numeric type randomization.
+  (hossman, Steve Rowe)
+
 ==================  6.7.0 ==================
 
 Consult the LUCENE_CHANGES.txt file for additional, low level, changes in this release.

http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/48be8ec1/solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
----------------------------------------------------------------------
diff --git a/solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java b/solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
index 6e23d45..0446093 100644
--- a/solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
+++ b/solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
@@ -2705,7 +2705,7 @@ public abstract class SolrTestCaseJ4 extends LuceneTestCase {
     System.setProperty(NUMERIC_DOCVALUES_SYSPROP, ""+useDV);
     
     // consume a consistent amount of random data even if sysprop/annotation is set
-    final boolean randUsePoints = random().nextBoolean();
+    final boolean randUsePoints = 0 != random().nextInt(5);  // 80% likelihood
 
     final String usePointsStr = System.getProperty(USE_NUMERIC_POINTS_SYSPROP);
     final boolean usePoints = (null == usePointsStr) ? randUsePoints : Boolean.parseBoolean(usePointsStr);