[jira] [Commented] (AIRFLOW-3063) Support all docker options to create containers with DockerOperator

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811177#comment-16811177 ] 

ASF GitHub Bot commented on AIRFLOW-3063:
-----------------------------------------

MerouaneBen commented on pull request #5049: [AIRFLOW-3063] - Make DockerOperator support all docker arguments
URL: https://github.com/apache/airflow/pull/5049
 
 
   A flexible implementation of dockerOperator class that takes all the
   containers config arguments in json kwargs dynamically.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3063
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   The default docker compose operator is great solution to isolate and scale the execution of dag tasks, but when it comes to use it in real complex tasks, we quickly notice that we can not use all the arguments and parameters to customise the containers available in the official Docker python lib. In this PR, we provide a flexible approach that allows to provide all the possible arguments for create_container method in kwargs object, instead of having only some of them listed in the constructor of the class.
   
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   The original unitest of docker operator lib where updated to work with the modifications implemented in the class, and some new unit tests have been added as well.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Support all docker options to create containers with DockerOperator
> -------------------------------------------------------------------
>
>                 Key: AIRFLOW-3063
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3063
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: docker
>    Affects Versions: 1.10.0
>            Reporter: Victor
>            Priority: Major
>
> The original need is to run a container in a predefined docker network, but I suppose the operator should support setting any of the options supported by the docker-py API.
> What is not totally clear is if it should be possible to define any of the options that can be passed to the docker API in a templated fashion or not.
> In my case, a temporary network could for example have been created in a previous operator and pushed to xcom.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)