You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Flavio Junqueira (JIRA)" <ji...@apache.org> on 2013/09/09 17:33:52 UTC
[jira] [Commented] (BOOKKEEPER-675) Log noise fixup before cutting
4.2.2
[ https://issues.apache.org/jira/browse/BOOKKEEPER-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13761932#comment-13761932 ]
Flavio Junqueira commented on BOOKKEEPER-675:
---------------------------------------------
Some comments:
# Please create a jira for the TODO in the patch;
# This change "+ channels.clear();" seems to be unrelated to this patch;
# You have changed some error messages to debug, like those in PerChannelBookieClient. They seem to represent some error condition or at least an error condition in a bookie. As such, they might impact the execution of the client and I would think that the severity level should be at least WARN.
> Log noise fixup before cutting 4.2.2
> ------------------------------------
>
> Key: BOOKKEEPER-675
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-675
> Project: Bookkeeper
> Issue Type: Wish
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.2, 4.3.0
>
> Attachments: 0001-BOOKKEEPER-675-Log-noise-fixup-before-cutting-4.2.2.patch, 0001-BOOKKEEPER-675-Log-noise-fixup-before-cutting-4.2.2.patch, 0001-BOOKKEEPER-675-Log-noise-fixup-trunk.patch, 0001-BOOKKEEPER-675-Log-noise-fixup-trunk.patch
>
>
> The message isn't a warning, but an information message that tells you that you initiated your cluster before instance ids existed, as such it should be info level so it doesn't show up on monitoring systems.
> WARN org.apache.bookkeeper.bookie.Bookie - INSTANCEID not exists in
> zookeeper. Not considering it for data verification
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira