You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/14 12:27:26 UTC

[GitHub] [flink] shidayang opened a new pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

shidayang opened a new pull request #17483:
URL: https://github.com/apache/flink/pull/17483


   Add a function can get row_kind, the function return "+I","-U","+U","-D"
   you can use this function as  "select row_kind() as op from xxx".


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143",
       "triggerID" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3bc3287fc97247888b7b3d9d027346efd34e9a8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054) 
   * 31f4b40e9131e91977b12f0425e55943f4461cec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143",
       "triggerID" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3bc3287fc97247888b7b3d9d027346efd34e9a8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054) 
   * 31f4b40e9131e91977b12f0425e55943f4461cec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143) 
   * 6a9d4e076ea0891039ee1cac272292049b1fdc3a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143",
       "triggerID" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25149",
       "triggerID" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6a9d4e076ea0891039ee1cac272292049b1fdc3a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25149) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] shidayang commented on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
shidayang commented on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-945476758


   @Airblader  Thanks for your review, I made some changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143",
       "triggerID" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25149",
       "triggerID" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 31f4b40e9131e91977b12f0425e55943f4461cec Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143) 
   * 6a9d4e076ea0891039ee1cac272292049b1fdc3a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25149) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143",
       "triggerID" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25149",
       "triggerID" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62cd4db84db65fa3fac6c405f22b85533873aff3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25252",
       "triggerID" : "62cd4db84db65fa3fac6c405f22b85533873aff3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6a9d4e076ea0891039ee1cac272292049b1fdc3a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25149) 
   * 62cd4db84db65fa3fac6c405f22b85533873aff3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25252) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143",
       "triggerID" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3bc3287fc97247888b7b3d9d027346efd34e9a8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054) 
   * 31f4b40e9131e91977b12f0425e55943f4461cec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143",
       "triggerID" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3bc3287fc97247888b7b3d9d027346efd34e9a8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054) 
   * 31f4b40e9131e91977b12f0425e55943f4461cec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143) 
   * 6a9d4e076ea0891039ee1cac272292049b1fdc3a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] Airblader commented on a change in pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17483:
URL: https://github.com/apache/flink/pull/17483#discussion_r729129963



##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala
##########
@@ -504,6 +504,19 @@ object GenerateUtils {
     GeneratedExpression(resultTerm, NEVER_NULL, resultCode, resultType)
   }
 
+  def generateRowKind(ctx: CodeGeneratorContext): GeneratedExpression = {
+    val resultType = new VarCharType(2)
+    val resultTypeTerm = primitiveTypeTermForType(resultType)
+    val resultTerm = ctx.addReusableLocalVariable(resultTypeTerm, "rowKind")
+    val resultCode =
+      s"""
+         |$resultTerm = org.apache.flink.table.data.binary.BinaryStringData.fromString(

Review comment:
       There's a constant for this class name




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143",
       "triggerID" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3bc3287fc97247888b7b3d9d027346efd34e9a8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054) 
   * 31f4b40e9131e91977b12f0425e55943f4461cec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143",
       "triggerID" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3bc3287fc97247888b7b3d9d027346efd34e9a8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054) 
   * 31f4b40e9131e91977b12f0425e55943f4461cec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143) 
   * 6a9d4e076ea0891039ee1cac272292049b1fdc3a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143",
       "triggerID" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3bc3287fc97247888b7b3d9d027346efd34e9a8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054) 
   * 31f4b40e9131e91977b12f0425e55943f4461cec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143",
       "triggerID" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3bc3287fc97247888b7b3d9d027346efd34e9a8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054) 
   * 31f4b40e9131e91977b12f0425e55943f4461cec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143",
       "triggerID" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3bc3287fc97247888b7b3d9d027346efd34e9a8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054) 
   * 31f4b40e9131e91977b12f0425e55943f4461cec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143) 
   * 6a9d4e076ea0891039ee1cac272292049b1fdc3a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143",
       "triggerID" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25149",
       "triggerID" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3bc3287fc97247888b7b3d9d027346efd34e9a8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054) 
   * 31f4b40e9131e91977b12f0425e55943f4461cec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143) 
   * 6a9d4e076ea0891039ee1cac272292049b1fdc3a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25149) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143",
       "triggerID" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25149",
       "triggerID" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62cd4db84db65fa3fac6c405f22b85533873aff3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25252",
       "triggerID" : "62cd4db84db65fa3fac6c405f22b85533873aff3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 62cd4db84db65fa3fac6c405f22b85533873aff3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25252) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943309923


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 3bc3287fc97247888b7b3d9d027346efd34e9a8c (Thu Oct 14 12:29:47 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-24547).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143",
       "triggerID" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3bc3287fc97247888b7b3d9d027346efd34e9a8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054) 
   * 31f4b40e9131e91977b12f0425e55943f4461cec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143) 
   * 6a9d4e076ea0891039ee1cac272292049b1fdc3a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3bc3287fc97247888b7b3d9d027346efd34e9a8c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143",
       "triggerID" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3bc3287fc97247888b7b3d9d027346efd34e9a8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054) 
   * 31f4b40e9131e91977b12f0425e55943f4461cec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143",
       "triggerID" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25149",
       "triggerID" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62cd4db84db65fa3fac6c405f22b85533873aff3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "62cd4db84db65fa3fac6c405f22b85533873aff3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6a9d4e076ea0891039ee1cac272292049b1fdc3a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25149) 
   * 62cd4db84db65fa3fac6c405f22b85533873aff3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3bc3287fc97247888b7b3d9d027346efd34e9a8c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] Airblader commented on a change in pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17483:
URL: https://github.com/apache/flink/pull/17483#discussion_r729124623



##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala
##########
@@ -504,6 +504,19 @@ object GenerateUtils {
     GeneratedExpression(resultTerm, NEVER_NULL, resultCode, resultType)
   }
 
+  def generateRowKind(ctx: CodeGeneratorContext): GeneratedExpression = {
+    val resultType = new VarCharType(2)
+    val resultTypeTerm = primitiveTypeTermForType(resultType)
+    val resultTerm = ctx.addReusableLocalVariable(resultTypeTerm, "rowKind")
+    val resultCode =
+      s"""
+         |$resultTerm = org.apache.flink.table.data.binary.BinaryStringData.fromString(
+         |$DEFAULT_INPUT1_TERM.getRowKind().shortString());
+         |""".stripMargin.trim
+    // the proctime has been materialized, so it's TIMESTAMP now, not PROCTIME_INDICATOR

Review comment:
       This comment makes no sense. Copy paste?

##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/StringCallGen.scala
##########
@@ -223,6 +222,9 @@ object StringCallGen {
           isCharacterString(operands(2).resultType) =>
         methodGen(BuiltInMethods.CONVERT_TZ)
 
+      case org.apache.flink.table.planner.functions.sql.FlinkSqlOperatorTable.ROW_KIND =>

Review comment:
       Please import `ROW_KIND` to shorten this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143",
       "triggerID" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3bc3287fc97247888b7b3d9d027346efd34e9a8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054) 
   * 31f4b40e9131e91977b12f0425e55943f4461cec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143) 
   * 6a9d4e076ea0891039ee1cac272292049b1fdc3a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143",
       "triggerID" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6a9d4e076ea0891039ee1cac272292049b1fdc3a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3bc3287fc97247888b7b3d9d027346efd34e9a8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054) 
   * 31f4b40e9131e91977b12f0425e55943f4461cec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143) 
   * 6a9d4e076ea0891039ee1cac272292049b1fdc3a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143",
       "triggerID" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3bc3287fc97247888b7b3d9d027346efd34e9a8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054) 
   * 31f4b40e9131e91977b12f0425e55943f4461cec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25143) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17483: [FLINK-24547][Table SQL / Planner]A function named row_kind() can get…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17483:
URL: https://github.com/apache/flink/pull/17483#issuecomment-943310958


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054",
       "triggerID" : "3bc3287fc97247888b7b3d9d027346efd34e9a8c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "31f4b40e9131e91977b12f0425e55943f4461cec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3bc3287fc97247888b7b3d9d027346efd34e9a8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25054) 
   * 31f4b40e9131e91977b12f0425e55943f4461cec UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org