You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Dave Brosius <db...@mebigfatguy.com> on 2013/06/29 23:08:14 UTC
Review Request 12192: set the field 'state' rather than the unread parameter
'state', if the parameter is null
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12192/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
code checks the parameter 'state' and if null, set it to Allocated, even though that parameter is never accessed. Meant to set the field 'state'.
Diffs
-----
engine/schema/src/com/cloud/network/dao/NetworkVO.java 6580ea0
Diff: https://reviews.apache.org/r/12192/diff/
Testing
-------
Thanks,
Dave Brosius
Re: Review Request 12192: set the field 'state' rather than the unread
parameter 'state', if the parameter is null
Posted by Dave Brosius <db...@mebigfatguy.com>.
> On July 2, 2013, 7:11 a.m., daan Hoogland wrote:
> > Your change seems fine.
> >
> > Did you regression test it? Or did you solve a problem with it?
Just noticed during code inspection
- Dave
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12192/#review22650
-----------------------------------------------------------
On June 29, 2013, 9:08 p.m., Dave Brosius wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12192/
> -----------------------------------------------------------
>
> (Updated June 29, 2013, 9:08 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> code checks the parameter 'state' and if null, set it to Allocated, even though that parameter is never accessed. Meant to set the field 'state'.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/network/dao/NetworkVO.java 6580ea0
>
> Diff: https://reviews.apache.org/r/12192/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dave Brosius
>
>
Re: Review Request 12192: set the field 'state' rather than the unread
parameter 'state', if the parameter is null
Posted by Sanjay Tripathi <sa...@citrix.com>.
> On July 2, 2013, 7:11 a.m., daan Hoogland wrote:
> > Your change seems fine.
> >
> > Did you regression test it? Or did you solve a problem with it?
>
> Dave Brosius wrote:
> Just noticed during code inspection
Dave, can you also open a ticket for this and mention your review request in the comment section of the ticket; it will help the community to track the issue.
- Sanjay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12192/#review22650
-----------------------------------------------------------
On June 29, 2013, 9:08 p.m., Dave Brosius wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12192/
> -----------------------------------------------------------
>
> (Updated June 29, 2013, 9:08 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> code checks the parameter 'state' and if null, set it to Allocated, even though that parameter is never accessed. Meant to set the field 'state'.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/network/dao/NetworkVO.java 6580ea0
>
> Diff: https://reviews.apache.org/r/12192/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dave Brosius
>
>
Re: Review Request 12192: set the field 'state' rather than the unread
parameter 'state', if the parameter is null
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12192/#review22650
-----------------------------------------------------------
Your change seems fine.
Did you regression test it? Or did you solve a problem with it?
- daan Hoogland
On June 29, 2013, 9:08 p.m., Dave Brosius wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12192/
> -----------------------------------------------------------
>
> (Updated June 29, 2013, 9:08 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> code checks the parameter 'state' and if null, set it to Allocated, even though that parameter is never accessed. Meant to set the field 'state'.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/network/dao/NetworkVO.java 6580ea0
>
> Diff: https://reviews.apache.org/r/12192/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dave Brosius
>
>
Re: Review Request 12192: set the field 'state' rather than the unread
parameter 'state', if the parameter is null
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12192/#review28615
-----------------------------------------------------------
Ship it!
3fd95fe231bdde6045b81fae0f6ff1bd4c2c0918
- daan Hoogland
On June 29, 2013, 9:08 p.m., Dave Brosius wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12192/
> -----------------------------------------------------------
>
> (Updated June 29, 2013, 9:08 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> code checks the parameter 'state' and if null, set it to Allocated, even though that parameter is never accessed. Meant to set the field 'state'.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/network/dao/NetworkVO.java 6580ea0
>
> Diff: https://reviews.apache.org/r/12192/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dave Brosius
>
>
Re: Review Request 12192: set the field 'state' rather than the unread
parameter 'state', if the parameter is null
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12192/#review24405
-----------------------------------------------------------
Review 12192 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #97 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/97/
- Jenkins Cloudstack.org
On June 29, 2013, 9:08 p.m., Dave Brosius wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12192/
> -----------------------------------------------------------
>
> (Updated June 29, 2013, 9:08 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> code checks the parameter 'state' and if null, set it to Allocated, even though that parameter is never accessed. Meant to set the field 'state'.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/network/dao/NetworkVO.java 6580ea0
>
> Diff: https://reviews.apache.org/r/12192/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dave Brosius
>
>
Re: Review Request 12192: set the field 'state' rather than the unread
parameter 'state', if the parameter is null
Posted by Amogh Vasekar <am...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12192/#review28418
-----------------------------------------------------------
Reminder-
Hi,
The review has been pending for long. Please update the patch since the build is failing.
Thanks
- Amogh Vasekar
On June 29, 2013, 9:08 p.m., Dave Brosius wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12192/
> -----------------------------------------------------------
>
> (Updated June 29, 2013, 9:08 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> code checks the parameter 'state' and if null, set it to Allocated, even though that parameter is never accessed. Meant to set the field 'state'.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/network/dao/NetworkVO.java 6580ea0
>
> Diff: https://reviews.apache.org/r/12192/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dave Brosius
>
>