You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/08/12 21:11:35 UTC
Review Request 13503: Fixed slave to always call
Isolator::resourcesChanged() when an executor re-registers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13503/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Bugs: MESOS-451
https://issues.apache.org/jira/browse/MESOS-451
Repository: mesos-git
Description
-------
This will also ensure that 'cfs' is retroactively applied to old live executors.
Diffs
-----
src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac
Diff: https://reviews.apache.org/r/13503/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13503: Fixed slave to always call
Isolator::resourcesChanged() when an executor re-registers.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13503/#review25044
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Aug. 12, 2013, 7:11 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13503/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2013, 7:11 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-451
> https://issues.apache.org/jira/browse/MESOS-451
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This will also ensure that 'cfs' is retroactively applied to old live executors.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac
>
> Diff: https://reviews.apache.org/r/13503/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13503: Fixed slave to always call
Isolator::resourcesChanged() when an executor re-registers.
Posted by Vinod Kone <vi...@gmail.com>.
> On Aug. 12, 2013, 8:51 p.m., Ben Mahler wrote:
> > src/slave/slave.cpp, lines 1637-1642
> > <https://reviews.apache.org/r/13503/diff/1/?file=340245#file340245line1637>
> >
> > The isolator has access to the ExecutorInfo, so can't it ensure that the resource isolation is updated when it recovers? Rather than relying on the slave to do this call?
isolator doesn't recover tasks, so it doesn't know about the total resource usage of executor + its tasks.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13503/#review25034
-----------------------------------------------------------
On Aug. 12, 2013, 7:11 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13503/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2013, 7:11 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-451
> https://issues.apache.org/jira/browse/MESOS-451
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This will also ensure that 'cfs' is retroactively applied to old live executors.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac
>
> Diff: https://reviews.apache.org/r/13503/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13503: Fixed slave to always call
Isolator::resourcesChanged() when an executor re-registers.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13503/#review25034
-----------------------------------------------------------
src/slave/slave.cpp
<https://reviews.apache.org/r/13503/#comment49192>
The isolator has access to the ExecutorInfo, so can't it ensure that the resource isolation is updated when it recovers? Rather than relying on the slave to do this call?
- Ben Mahler
On Aug. 12, 2013, 7:11 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13503/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2013, 7:11 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-451
> https://issues.apache.org/jira/browse/MESOS-451
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This will also ensure that 'cfs' is retroactively applied to old live executors.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac
>
> Diff: https://reviews.apache.org/r/13503/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>