[jira] [Commented] (MAPREDUCE-3128) WebAppContext should also be stopped and cleared

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118020#comment-13118020 ] 

Hadoop QA commented on MAPREDUCE-3128:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12497150/MAPREDUCE-3128.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/910//console

This message is automatically generated.
                
> WebAppContext should also be stopped and cleared
> ------------------------------------------------
>
>                 Key: MAPREDUCE-3128
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3128
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.24.0
>            Reporter: Devaraj K
>            Assignee: Devaraj K
>             Fix For: 0.24.0
>
>         Attachments: MAPREDUCE-3128.patch
>
>
> 1. If listener stop method throws any exception then the webserver stop method will not be called
> {code}
> public void stop() throws Exception {
>     listener.close();
>     webServer.stop();
> }
> {code}
> 2. also, WebAppContext stores all the context attributes, which does not get cleared if only webServer is stopped.
> so following calls are necessary to ensure clean and complete stop.
> {code}
> webAppContext.clearAttributes();
> webAppContext.stop();
> {code}
> 3. Also the WebAppContext display name can be the name passed to HttpServer instance.
> {code}
> webAppContext.setDisplayName(name);
> {code}
> instead of
> {code}
> webAppContext.setDisplayName("WepAppsContext");
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira