You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Jesper Skov (JIRA)" <ji...@apache.org> on 2010/06/19 16:24:38 UTC

[jira] Created: (BUILDR-458) Spurious . files added in zip archives when using :as renaming

Spurious . files added in zip archives when using :as renaming
--------------------------------------------------------------

                 Key: BUILDR-458
                 URL: https://issues.apache.org/jira/browse/BUILDR-458
             Project: Buildr
          Issue Type: Bug
          Components: JRuby
    Affects Versions: 1.4
         Environment: OS X 10.5.8
jruby 1.5.1 (ruby 1.8.7 patchlevel 249) (2010-06-06 f3a3480) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_20) [x86_64-java]
            Reporter: Jesper Skov


The below buildr example produces a broken (java-wise anyway) zip file with this content:

{code}
Archive:  target/testProject-1.0.0.zip
  Length     Date   Time    Name
 --------    ----   ----    ----
       26  06-19-10 16:18   .
        0  06-19-10 16:18   dir/
       26  06-19-10 16:18   dir/bar
        9  06-19-10 16:18   foo
 --------                   -------
       61                   4 files
{code}

Note the presence of the file {{.}} which appears to be a duplicate of the {{dir/bar}} file.


{code}
# Generated by Buildr 1.4.0, change to your liking
# Version number for this release
VERSION_NUMBER = "1.0.0"
# Group identifier for your projects
GROUP = "testProject"
COPYRIGHT = ""

# Specify Maven 2.0 remote repositories here, like this:
repositories.remote << "http://www.ibiblio.org/maven2/"

desc "The TestProject project"
define "testProject" do

  project.version = VERSION_NUMBER
  project.group = GROUP
  manifest["Implementation-Vendor"] = COPYRIGHT

  build do
    FileUtils.mkdir_p(_(:target, "test/bar"))
    FileUtils.touch(_(:target, "test/foo"))
    FileUtils.touch(_(:target, "test/bar/foo"))
  end

# Works as expected
#  package(:zip).include(_(:target, "test/**"))

  # Adds . in root folder of archive
  package(:zip).include(_(:target, "test"), :as => ".")

end
{code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (BUILDR-458) Spurious . files added in zip archives when using :as renaming

Posted by "Jesper Skov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesper Skov closed BUILDR-458.
------------------------------

    Fix Version/s: 1.4
       Resolution: Fixed

Yes, using 1.4GA fixed the problem.

Sorry for the noise.

> Spurious . files added in zip archives when using :as renaming
> --------------------------------------------------------------
>
>                 Key: BUILDR-458
>                 URL: https://issues.apache.org/jira/browse/BUILDR-458
>             Project: Buildr
>          Issue Type: Bug
>          Components: JRuby
>    Affects Versions: 1.4
>         Environment: OS X 10.5.8
> jruby 1.5.1 (ruby 1.8.7 patchlevel 249) (2010-06-06 f3a3480) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_20) [x86_64-java]
>            Reporter: Jesper Skov
>            Assignee: Antoine Toulme
>             Fix For: 1.4
>
>
> The below buildr example produces a broken (java-wise anyway) zip file with this content:
> {code}
> Archive:  target/testProject-1.0.0.zip
>   Length     Date   Time    Name
>  --------    ----   ----    ----
>        26  06-19-10 16:18   .
>         0  06-19-10 16:18   dir/
>        26  06-19-10 16:18   dir/bar
>         9  06-19-10 16:18   foo
>  --------                   -------
>        61                   4 files
> {code}
> Note the presence of the file {{.}} which appears to be a duplicate of the {{dir/bar}} file.
> {code}
> # Generated by Buildr 1.4.0, change to your liking
> # Version number for this release
> VERSION_NUMBER = "1.0.0"
> # Group identifier for your projects
> GROUP = "testProject"
> COPYRIGHT = ""
> # Specify Maven 2.0 remote repositories here, like this:
> repositories.remote << "http://www.ibiblio.org/maven2/"
> desc "The TestProject project"
> define "testProject" do
>   project.version = VERSION_NUMBER
>   project.group = GROUP
>   manifest["Implementation-Vendor"] = COPYRIGHT
>   build do
>     FileUtils.mkdir_p(_(:target, "test/dir"))
>     File.open(_(:target, "test/foo"), "w") { | f | f.puts("foo file") }
>     File.open(_(:target, "test/dir/bar"), "w") { | f | f.puts("bar file with longer text") }
>   end
> # Works as expected
> #  package(:zip).include(_(:target, "test/**"))
>   # Adds . in root folder of archive
>   package(:zip).include(_(:target, "test"), :as => ".")
> end
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (BUILDR-458) Spurious . files added in zip archives when using :as renaming

Posted by "Jesper Skov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesper Skov updated BUILDR-458:
-------------------------------

    Description: 
The below buildr example produces a broken (java-wise anyway) zip file with this content:

{code}
Archive:  target/testProject-1.0.0.zip
  Length     Date   Time    Name
 --------    ----   ----    ----
       26  06-19-10 16:18   .
        0  06-19-10 16:18   dir/
       26  06-19-10 16:18   dir/bar
        9  06-19-10 16:18   foo
 --------                   -------
       61                   4 files
{code}

Note the presence of the file {{.}} which appears to be a duplicate of the {{dir/bar}} file.


{code}
# Generated by Buildr 1.4.0, change to your liking
# Version number for this release
VERSION_NUMBER = "1.0.0"
# Group identifier for your projects
GROUP = "testProject"
COPYRIGHT = ""

# Specify Maven 2.0 remote repositories here, like this:
repositories.remote << "http://www.ibiblio.org/maven2/"

desc "The TestProject project"
define "testProject" do

  project.version = VERSION_NUMBER
  project.group = GROUP
  manifest["Implementation-Vendor"] = COPYRIGHT

  build do
    FileUtils.mkdir_p(_(:target, "test/dir"))
    File.open(_(:target, "test/foo"), "w") { | f | f.puts("foo file") }
    File.open(_(:target, "test/dir/bar"), "w") { | f | f.puts("bar file with longer text") }
  end

# Works as expected
#  package(:zip).include(_(:target, "test/**"))

  # Adds . in root folder of archive
  package(:zip).include(_(:target, "test"), :as => ".")

end
{code}

  was:
The below buildr example produces a broken (java-wise anyway) zip file with this content:

{code}
Archive:  target/testProject-1.0.0.zip
  Length     Date   Time    Name
 --------    ----   ----    ----
       26  06-19-10 16:18   .
        0  06-19-10 16:18   dir/
       26  06-19-10 16:18   dir/bar
        9  06-19-10 16:18   foo
 --------                   -------
       61                   4 files
{code}

Note the presence of the file {{.}} which appears to be a duplicate of the {{dir/bar}} file.


{code}
# Generated by Buildr 1.4.0, change to your liking
# Version number for this release
VERSION_NUMBER = "1.0.0"
# Group identifier for your projects
GROUP = "testProject"
COPYRIGHT = ""

# Specify Maven 2.0 remote repositories here, like this:
repositories.remote << "http://www.ibiblio.org/maven2/"

desc "The TestProject project"
define "testProject" do

  project.version = VERSION_NUMBER
  project.group = GROUP
  manifest["Implementation-Vendor"] = COPYRIGHT

  build do
    FileUtils.mkdir_p(_(:target, "test/bar"))
    FileUtils.touch(_(:target, "test/foo"))
    FileUtils.touch(_(:target, "test/bar/foo"))
  end

# Works as expected
#  package(:zip).include(_(:target, "test/**"))

  # Adds . in root folder of archive
  package(:zip).include(_(:target, "test"), :as => ".")

end
{code}


> Spurious . files added in zip archives when using :as renaming
> --------------------------------------------------------------
>
>                 Key: BUILDR-458
>                 URL: https://issues.apache.org/jira/browse/BUILDR-458
>             Project: Buildr
>          Issue Type: Bug
>          Components: JRuby
>    Affects Versions: 1.4
>         Environment: OS X 10.5.8
> jruby 1.5.1 (ruby 1.8.7 patchlevel 249) (2010-06-06 f3a3480) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_20) [x86_64-java]
>            Reporter: Jesper Skov
>
> The below buildr example produces a broken (java-wise anyway) zip file with this content:
> {code}
> Archive:  target/testProject-1.0.0.zip
>   Length     Date   Time    Name
>  --------    ----   ----    ----
>        26  06-19-10 16:18   .
>         0  06-19-10 16:18   dir/
>        26  06-19-10 16:18   dir/bar
>         9  06-19-10 16:18   foo
>  --------                   -------
>        61                   4 files
> {code}
> Note the presence of the file {{.}} which appears to be a duplicate of the {{dir/bar}} file.
> {code}
> # Generated by Buildr 1.4.0, change to your liking
> # Version number for this release
> VERSION_NUMBER = "1.0.0"
> # Group identifier for your projects
> GROUP = "testProject"
> COPYRIGHT = ""
> # Specify Maven 2.0 remote repositories here, like this:
> repositories.remote << "http://www.ibiblio.org/maven2/"
> desc "The TestProject project"
> define "testProject" do
>   project.version = VERSION_NUMBER
>   project.group = GROUP
>   manifest["Implementation-Vendor"] = COPYRIGHT
>   build do
>     FileUtils.mkdir_p(_(:target, "test/dir"))
>     File.open(_(:target, "test/foo"), "w") { | f | f.puts("foo file") }
>     File.open(_(:target, "test/dir/bar"), "w") { | f | f.puts("bar file with longer text") }
>   end
> # Works as expected
> #  package(:zip).include(_(:target, "test/**"))
>   # Adds . in root folder of archive
>   package(:zip).include(_(:target, "test"), :as => ".")
> end
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-458) Spurious . files added in zip archives when using :as renaming

Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880717#action_12880717 ] 

Antoine Toulme commented on BUILDR-458:
---------------------------------------

I'm asking because BUILDR-457 is the exact same bug and we fixed it last week.

> Spurious . files added in zip archives when using :as renaming
> --------------------------------------------------------------
>
>                 Key: BUILDR-458
>                 URL: https://issues.apache.org/jira/browse/BUILDR-458
>             Project: Buildr
>          Issue Type: Bug
>          Components: JRuby
>    Affects Versions: 1.4
>         Environment: OS X 10.5.8
> jruby 1.5.1 (ruby 1.8.7 patchlevel 249) (2010-06-06 f3a3480) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_20) [x86_64-java]
>            Reporter: Jesper Skov
>
> The below buildr example produces a broken (java-wise anyway) zip file with this content:
> {code}
> Archive:  target/testProject-1.0.0.zip
>   Length     Date   Time    Name
>  --------    ----   ----    ----
>        26  06-19-10 16:18   .
>         0  06-19-10 16:18   dir/
>        26  06-19-10 16:18   dir/bar
>         9  06-19-10 16:18   foo
>  --------                   -------
>        61                   4 files
> {code}
> Note the presence of the file {{.}} which appears to be a duplicate of the {{dir/bar}} file.
> {code}
> # Generated by Buildr 1.4.0, change to your liking
> # Version number for this release
> VERSION_NUMBER = "1.0.0"
> # Group identifier for your projects
> GROUP = "testProject"
> COPYRIGHT = ""
> # Specify Maven 2.0 remote repositories here, like this:
> repositories.remote << "http://www.ibiblio.org/maven2/"
> desc "The TestProject project"
> define "testProject" do
>   project.version = VERSION_NUMBER
>   project.group = GROUP
>   manifest["Implementation-Vendor"] = COPYRIGHT
>   build do
>     FileUtils.mkdir_p(_(:target, "test/dir"))
>     File.open(_(:target, "test/foo"), "w") { | f | f.puts("foo file") }
>     File.open(_(:target, "test/dir/bar"), "w") { | f | f.puts("bar file with longer text") }
>   end
> # Works as expected
> #  package(:zip).include(_(:target, "test/**"))
>   # Adds . in root folder of archive
>   package(:zip).include(_(:target, "test"), :as => ".")
> end
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-458) Spurious . files added in zip archives when using :as renaming

Posted by "Jesper Skov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880847#action_12880847 ] 

Jesper Skov commented on BUILDR-458:
------------------------------------

I was using RC4. I see the checksum on the GA is different. I'll give that a shot.

> Spurious . files added in zip archives when using :as renaming
> --------------------------------------------------------------
>
>                 Key: BUILDR-458
>                 URL: https://issues.apache.org/jira/browse/BUILDR-458
>             Project: Buildr
>          Issue Type: Bug
>          Components: JRuby
>    Affects Versions: 1.4
>         Environment: OS X 10.5.8
> jruby 1.5.1 (ruby 1.8.7 patchlevel 249) (2010-06-06 f3a3480) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_20) [x86_64-java]
>            Reporter: Jesper Skov
>            Assignee: Antoine Toulme
>
> The below buildr example produces a broken (java-wise anyway) zip file with this content:
> {code}
> Archive:  target/testProject-1.0.0.zip
>   Length     Date   Time    Name
>  --------    ----   ----    ----
>        26  06-19-10 16:18   .
>         0  06-19-10 16:18   dir/
>        26  06-19-10 16:18   dir/bar
>         9  06-19-10 16:18   foo
>  --------                   -------
>        61                   4 files
> {code}
> Note the presence of the file {{.}} which appears to be a duplicate of the {{dir/bar}} file.
> {code}
> # Generated by Buildr 1.4.0, change to your liking
> # Version number for this release
> VERSION_NUMBER = "1.0.0"
> # Group identifier for your projects
> GROUP = "testProject"
> COPYRIGHT = ""
> # Specify Maven 2.0 remote repositories here, like this:
> repositories.remote << "http://www.ibiblio.org/maven2/"
> desc "The TestProject project"
> define "testProject" do
>   project.version = VERSION_NUMBER
>   project.group = GROUP
>   manifest["Implementation-Vendor"] = COPYRIGHT
>   build do
>     FileUtils.mkdir_p(_(:target, "test/dir"))
>     File.open(_(:target, "test/foo"), "w") { | f | f.puts("foo file") }
>     File.open(_(:target, "test/dir/bar"), "w") { | f | f.puts("bar file with longer text") }
>   end
> # Works as expected
> #  package(:zip).include(_(:target, "test/**"))
>   # Adds . in root folder of archive
>   package(:zip).include(_(:target, "test"), :as => ".")
> end
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-458) Spurious . files added in zip archives when using :as renaming

Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880708#action_12880708 ] 

Antoine Toulme commented on BUILDR-458:
---------------------------------------

Did you try this with the 1.4 GA ?

> Spurious . files added in zip archives when using :as renaming
> --------------------------------------------------------------
>
>                 Key: BUILDR-458
>                 URL: https://issues.apache.org/jira/browse/BUILDR-458
>             Project: Buildr
>          Issue Type: Bug
>          Components: JRuby
>    Affects Versions: 1.4
>         Environment: OS X 10.5.8
> jruby 1.5.1 (ruby 1.8.7 patchlevel 249) (2010-06-06 f3a3480) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_20) [x86_64-java]
>            Reporter: Jesper Skov
>
> The below buildr example produces a broken (java-wise anyway) zip file with this content:
> {code}
> Archive:  target/testProject-1.0.0.zip
>   Length     Date   Time    Name
>  --------    ----   ----    ----
>        26  06-19-10 16:18   .
>         0  06-19-10 16:18   dir/
>        26  06-19-10 16:18   dir/bar
>         9  06-19-10 16:18   foo
>  --------                   -------
>        61                   4 files
> {code}
> Note the presence of the file {{.}} which appears to be a duplicate of the {{dir/bar}} file.
> {code}
> # Generated by Buildr 1.4.0, change to your liking
> # Version number for this release
> VERSION_NUMBER = "1.0.0"
> # Group identifier for your projects
> GROUP = "testProject"
> COPYRIGHT = ""
> # Specify Maven 2.0 remote repositories here, like this:
> repositories.remote << "http://www.ibiblio.org/maven2/"
> desc "The TestProject project"
> define "testProject" do
>   project.version = VERSION_NUMBER
>   project.group = GROUP
>   manifest["Implementation-Vendor"] = COPYRIGHT
>   build do
>     FileUtils.mkdir_p(_(:target, "test/dir"))
>     File.open(_(:target, "test/foo"), "w") { | f | f.puts("foo file") }
>     File.open(_(:target, "test/dir/bar"), "w") { | f | f.puts("bar file with longer text") }
>   end
> # Works as expected
> #  package(:zip).include(_(:target, "test/**"))
>   # Adds . in root folder of archive
>   package(:zip).include(_(:target, "test"), :as => ".")
> end
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (BUILDR-458) Spurious . files added in zip archives when using :as renaming

Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antoine Toulme reassigned BUILDR-458:
-------------------------------------

    Assignee: Antoine Toulme

> Spurious . files added in zip archives when using :as renaming
> --------------------------------------------------------------
>
>                 Key: BUILDR-458
>                 URL: https://issues.apache.org/jira/browse/BUILDR-458
>             Project: Buildr
>          Issue Type: Bug
>          Components: JRuby
>    Affects Versions: 1.4
>         Environment: OS X 10.5.8
> jruby 1.5.1 (ruby 1.8.7 patchlevel 249) (2010-06-06 f3a3480) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_20) [x86_64-java]
>            Reporter: Jesper Skov
>            Assignee: Antoine Toulme
>
> The below buildr example produces a broken (java-wise anyway) zip file with this content:
> {code}
> Archive:  target/testProject-1.0.0.zip
>   Length     Date   Time    Name
>  --------    ----   ----    ----
>        26  06-19-10 16:18   .
>         0  06-19-10 16:18   dir/
>        26  06-19-10 16:18   dir/bar
>         9  06-19-10 16:18   foo
>  --------                   -------
>        61                   4 files
> {code}
> Note the presence of the file {{.}} which appears to be a duplicate of the {{dir/bar}} file.
> {code}
> # Generated by Buildr 1.4.0, change to your liking
> # Version number for this release
> VERSION_NUMBER = "1.0.0"
> # Group identifier for your projects
> GROUP = "testProject"
> COPYRIGHT = ""
> # Specify Maven 2.0 remote repositories here, like this:
> repositories.remote << "http://www.ibiblio.org/maven2/"
> desc "The TestProject project"
> define "testProject" do
>   project.version = VERSION_NUMBER
>   project.group = GROUP
>   manifest["Implementation-Vendor"] = COPYRIGHT
>   build do
>     FileUtils.mkdir_p(_(:target, "test/dir"))
>     File.open(_(:target, "test/foo"), "w") { | f | f.puts("foo file") }
>     File.open(_(:target, "test/dir/bar"), "w") { | f | f.puts("bar file with longer text") }
>   end
> # Works as expected
> #  package(:zip).include(_(:target, "test/**"))
>   # Adds . in root folder of archive
>   package(:zip).include(_(:target, "test"), :as => ".")
> end
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.