You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/01 13:01:58 UTC
[GitHub] [pulsar] codelipenghui opened a new pull request, #16334: [improve][java-client] Support passing existing scheduled executor providers to the client
codelipenghui opened a new pull request, #16334:
URL: https://github.com/apache/pulsar/pull/16334
### Motivation
#16236 introduced a new scheduled executor but does not support passing the existing scheduled executor providers like #12037.
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a diff in pull request #16334: [improve][java-client] Support passing existing scheduled executor providers to the client
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on code in PR #16334:
URL: https://github.com/apache/pulsar/pull/16334#discussion_r912111979
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java:
##########
@@ -196,8 +197,8 @@ private PulsarClientImpl(ClientConfigurationData conf, EventLoopGroup eventLoopG
new ExecutorProvider(conf.getNumListenerThreads(), "pulsar-external-listener");
this.internalExecutorProvider = internalExecutorProvider != null ? internalExecutorProvider :
new ExecutorProvider(conf.getNumIoThreads(), "pulsar-client-internal");
- this.scheduledExecutorProvider = new ScheduledExecutorProvider(conf.getNumIoThreads(),
- "pulsar-client-scheduled");
+ this.scheduledExecutorProvider = scheduledExecutorProvider != null ? scheduledExecutorProvider :
Review Comment:
@merlimat Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a diff in pull request #16334: [improve][java-client] Support passing existing scheduled executor providers to the client
Posted by GitBox <gi...@apache.org>.
merlimat commented on code in PR #16334:
URL: https://github.com/apache/pulsar/pull/16334#discussion_r912050457
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java:
##########
@@ -196,8 +197,8 @@ private PulsarClientImpl(ClientConfigurationData conf, EventLoopGroup eventLoopG
new ExecutorProvider(conf.getNumListenerThreads(), "pulsar-external-listener");
this.internalExecutorProvider = internalExecutorProvider != null ? internalExecutorProvider :
new ExecutorProvider(conf.getNumIoThreads(), "pulsar-client-internal");
- this.scheduledExecutorProvider = new ScheduledExecutorProvider(conf.getNumIoThreads(),
- "pulsar-client-scheduled");
+ this.scheduledExecutorProvider = scheduledExecutorProvider != null ? scheduledExecutorProvider :
Review Comment:
Shouldn’t we consider whether it was passed in or created internally, at the moment of closing it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #16334: [improve][java-client] Support passing existing scheduled executor providers to the client
Posted by GitBox <gi...@apache.org>.
merlimat merged PR #16334:
URL: https://github.com/apache/pulsar/pull/16334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org