You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2015/05/02 03:10:17 UTC
Re: Review Request 33100: Stack Validator fails when when HBase
properties
hbase_master_heapsize or hbase_regionserver_heapsize are added to both
hbase-env and hbase-site - returns 500 error
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33100/#review82305
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On April 11, 2015, 2:13 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33100/
> -----------------------------------------------------------
>
> (Updated April 11, 2015, 2:13 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Gautam Borad, Myroslav Papirkovskyy, Srimanth Gunturi, and Sid Wagle.
>
>
> Bugs: AMBARI-10451
> https://issues.apache.org/jira/browse/AMBARI-10451
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari 2.0.0 with HDP 2.2.0.0, HBase has these two properties in hbase-env,
> hbase_master_heapsize
> hbase_regionserver_heapsize
> If a user attempts to add them to hbase-site, then saving the configs will fail.
> Today, the hbase-site validator checks both hbase-site and hbase-env using the recommended properties for hbase-site. This causes a failure because the properties will exist in the hbase-site configs, but not in the recommended params for it.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRunner.java 191aeed
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 08badf8
> ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 3a42a3d
>
> Diff: https://reviews.apache.org/r/33100/diff/
>
>
> Testing
> -------
>
> Reproduced the issue on a live cluster and verified that the following works.
> A. hbase-env hbase_master_heapsize set to 512 fails
> B. hbase-env hbase_master_heapsize set to 1024 passes
> C. Scenario B + hbase-site hbase_master_heapsize set 512 passes since that property is not checked
> D. Introduced an error in the stack_validation.py on purpose to test the error message in the dialog box
>
> Unit tests are in progress.
>
>
> Thanks,
>
> Alejandro Fernandez
>
>