[GitHub] [ignite] alex-plekhanov commented on a change in pull request #9671: IGNITE-16111 Index rebuild handling

[GitBox <gi...@apache.org>]

alex-plekhanov commented on a change in pull request #9671:
URL: https://github.com/apache/ignite/pull/9671#discussion_r796603349



##########
File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/rel/IgniteIndexScan.java
##########
@@ -39,13 +41,18 @@
     /** */
     private final long sourceId;
 
+    /** */
+    private final RelCollation idxCollation;
+
     /**
      * Constructor used for deserialization.
      *
      * @param input Serialized representation.
      */
     public IgniteIndexScan(RelInput input) {
-        super(changeTraits(input, IgniteConvention.INSTANCE));
+        super(changeTraits(input, IgniteConvention.INSTANCE, input.getCollation()));

Review comment:
       Sort relations don't have projections and "required columns", so sorting collation and trait collation are the same here. For index scans index collation and trait collation is different and there is confusion. Perhaps, it's better to store index collation in the "collation" field and restore output collation on remote nodes by index collation and projects. It's much easier than restoring index collation by bounds as currently implemented in this patch. WDYT? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org