You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2023/01/05 11:14:55 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request, #7057: server/UI: fix some issues with network offering details
weizhouapache opened a new pull request, #7057:
URL: https://github.com/apache/cloudstack/pull/7057
### Description
This PR fixes some issues with network offering details
(1) on UI: the serviceofferingid and maclearning is not passed to API when create network offering
(2) when create network offering, the details are not saved except internetprotocol, including
Promiscuous mode
MAC address changes
Forged transmits
MAC learning
(3) network offering details are not removed when delete a network offering.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [x] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#discussion_r1064743445
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -6408,7 +6408,9 @@ public NetworkOfferingVO doInTransaction(final TransactionStatus status) {
detailsVO.add(new NetworkOfferingDetailsVO(offering.getId(), Detail.internetProtocol, String.valueOf(internetProtocol), true));
}
if (!detailsVO.isEmpty()) {
- networkOfferingDetailsDao.saveDetails(detailsVO);
Review Comment:
This is one of those mega methods that need disecting to understand (out of scope). I think @weizhouapache is right,a though it is strange that some of the details should already exist for a network offering we are busy creating.
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -6769,6 +6771,7 @@ public boolean deleteNetworkOffering(final DeleteNetworkOfferingCmd cmd) {
annotationDao.removeByEntityType(AnnotationService.EntityType.NETWORK_OFFERING.name(), offering.getUuid());
if (_networkOfferingDao.remove(offeringId)) {
+ networkOfferingDetailsDao.removeDetails(offeringId);
Review Comment:
shouldn´t we first remove the details and than the oddering?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#discussion_r1062406906
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -6408,7 +6408,9 @@ public NetworkOfferingVO doInTransaction(final TransactionStatus status) {
detailsVO.add(new NetworkOfferingDetailsVO(offering.getId(), Detail.internetProtocol, String.valueOf(internetProtocol), true));
}
if (!detailsVO.isEmpty()) {
- networkOfferingDetailsDao.saveDetails(detailsVO);
Review Comment:
> @weizhouapache this is used while creating a new offering so will it matter even if the code tries to delete existing details for the resourceId (service offering is here)?
@shwstppr yes, there are some network offering details passed via API.
https://cloudstack.apache.org/api/apidocs-4.17/apis/createNetworkOffering.html
for example, the following details are not saved
Promiscuous mode
MAC address changes
Forged transmits
MAC learning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#issuecomment-1376013338
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#issuecomment-1377273295
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#issuecomment-1378597250
@shwstppr is this lgty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#issuecomment-1375938685
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#discussion_r1062365397
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -6408,7 +6408,9 @@ public NetworkOfferingVO doInTransaction(final TransactionStatus status) {
detailsVO.add(new NetworkOfferingDetailsVO(offering.getId(), Detail.internetProtocol, String.valueOf(internetProtocol), true));
}
if (!detailsVO.isEmpty()) {
- networkOfferingDetailsDao.saveDetails(detailsVO);
Review Comment:
`saveDetails` will firstly remove all existing details. this causes issue (2) in the PR decription.
in my opinion. the issue is critical . @DaanHoogland @rohityadavcloud @shwstppr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a diff in pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
shwstppr commented on code in PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#discussion_r1062388174
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -6408,7 +6408,9 @@ public NetworkOfferingVO doInTransaction(final TransactionStatus status) {
detailsVO.add(new NetworkOfferingDetailsVO(offering.getId(), Detail.internetProtocol, String.valueOf(internetProtocol), true));
}
if (!detailsVO.isEmpty()) {
- networkOfferingDetailsDao.saveDetails(detailsVO);
Review Comment:
@weizhouapache this is used while creating a new offering so will it matter even if the code tries to delete existing details for the resourceId (service offering is here)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#issuecomment-1376012694
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#issuecomment-1377119379
<b>Trillian test result (tid-5781)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38630 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7057-t5781-kvm-centos7.zip
Smoke tests completed. 96 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_list_snapshots_with_removed_data_store | `Error` | 9.42 | test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 9.42 | test_snapshots.py
test_01_add_primary_storage_disabled_host | `Error` | 0.63 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.11 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.20 | test_primary_storage.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 32.87 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 59.41 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 37.97 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 35.94 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 118.77 | test_kubernetes_clusters.py
test_01_secure_vm_migration | `Error` | 154.43 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 268.31 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 136.94 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 43.84 | test_vm_life_cycle.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 302.79 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#issuecomment-1377276054
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#issuecomment-1378229339
<b>Trillian test result (tid-5790)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39556 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7057-t5790-kvm-centos7.zip
Smoke tests completed. 100 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_upgrade_kubernetes_cluster | `Failure` | 472.65 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 617.17 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#discussion_r1064764531
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -6769,6 +6771,7 @@ public boolean deleteNetworkOffering(final DeleteNetworkOfferingCmd cmd) {
annotationDao.removeByEntityType(AnnotationService.EntityType.NETWORK_OFFERING.name(), offering.getUuid());
if (_networkOfferingDao.remove(offeringId)) {
+ networkOfferingDetailsDao.removeDetails(offeringId);
Review Comment:
thanks Daan.
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#issuecomment-1377585345
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#issuecomment-1372206323
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7057](https://codecov.io/gh/apache/cloudstack/pull/7057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bce6829) into [4.17](https://codecov.io/gh/apache/cloudstack/commit/89d4c7537fde8092f99c0fc61f8a5e5921ea5733?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (89d4c75) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## 4.17 #7057 +/- ##
============================================
- Coverage 10.36% 10.36% -0.01%
+ Complexity 6633 6629 -4
============================================
Files 2453 2453
Lines 242386 242389 +3
Branches 37928 37929 +1
============================================
- Hits 25133 25125 -8
- Misses 214144 214156 +12
+ Partials 3109 3108 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../cloud/configuration/ConfigurationManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2NvbmZpZ3VyYXRpb24vQ29uZmlndXJhdGlvbk1hbmFnZXJJbXBsLmphdmE=) | `10.84% <0.00%> (-0.01%)` | :arrow_down: |
| [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/7057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `21.15% <0.00%> (-7.70%)` | :arrow_down: |
| [...apache/cloudstack/syslog/AlertsSyslogAppender.java](https://codecov.io/gh/apache/cloudstack/pull/7057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zeXNsb2ctYWxlcnRzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N5c2xvZy9BbGVydHNTeXNsb2dBcHBlbmRlci5qYXZh) | `56.49% <0.00%> (-2.26%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#issuecomment-1375939994
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#issuecomment-1377586827
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#issuecomment-1377350437
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#issuecomment-1372088608
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #7057: server/UI: fix some issues with network offering details
URL: https://github.com/apache/cloudstack/pull/7057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#issuecomment-1376006851
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #7057: server/UI: fix some issues with network offering details
URL: https://github.com/apache/cloudstack/pull/7057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#issuecomment-1372089692
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7057: server/UI: fix some issues with network offering details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#issuecomment-1372130447
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org