[GitHub] [superset] mayurnewase commented on a diff in pull request #21729: fix: allow adhoc query in chart columns

[GitBox <gi...@apache.org>]

mayurnewase commented on code in PR #21729:
URL: https://github.com/apache/superset/pull/21729#discussion_r989674005


##########
superset/connectors/sqla/models.py:
##########
@@ -1438,15 +1440,24 @@ def get_sqla_query(  # pylint: disable=too-many-arguments,too-many-locals,too-ma
                 select_exprs.append(outer)
         elif columns:
             for selected in columns:
+                if isinstance(selected, dict):

Review Comment:
   this is the real change, everything else is just setting proper types for columns.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org