[GitHub] [iceberg] Fokko commented on issue #4985: Conform Python API to tablespec

[GitBox <gi...@apache.org>]

Fokko commented on issue #4985:
URL: https://github.com/apache/iceberg/issues/4985#issuecomment-1149145976

   I went ahead and created a PR https://github.com/apache/iceberg/pull/4992
   
   @rdblue suggested to keep `_type` postfix for `element` for the List, `key` and `value` for the Map. This is in line with the `field_type` of the NestedField. Also, Java also uses `keyType`: https://github.com/apache/iceberg/blob/master/api/src/main/java/org/apache/iceberg/types/Types.java#L761-L777
   
   Next to that, Java uses `keyField`, so this also nicely aligns then by renaming `key` into `key_field` in Python.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org