You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Milamber <mi...@apache.org> on 2015/03/22 17:54:52 UTC
Re: svn commit: r1668373 - in /jmeter/trunk:
src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
xdocs/changes.xml
This commit brings an issue:
batchtest:
[echo] Starting HTMLParserTestFile_2 using -X
[jmeter] Creating summariser <summary>
[jmeter] Created the tree successfully using
testfiles/HTMLParserTestFile_2.jmx
[jmeter] Starting the test @ Sun Mar 22 16:39:37 WET 2015 (1427042377663)
[jmeter] Waiting for possible shutdown message on port 4445
[jmeter] summary = 1 in 0.3s = 4.0/s Avg: 173 Min: 173
Max: 173 Err: 0 (0.00%)
[jmeter] Tidying up ... @ Sun Mar 22 16:39:38 WET 2015 (1427042378328)
[jmeter] ... end of run
BUILD FAILED
/home/milamber/temp/jmetertemp/build.xml:2563: The following error
occurred while executing this line:
/home/milamber/temp/jmetertemp/build.xml:2531: CSV Files are not identical.
/home/milamber/temp/jmetertemp/bin/testfiles/HTMLParserTestFile_2.csv
/home/milamber/temp/jmetertemp/bin/HTMLParserTestFile_2.csv
Total time: 3 minutes 52 seconds
milamber@ender:~/temp/jmetertemp$ diff
/home/milamber/temp/jmetertemp/bin/HTMLParserTestFile_2.csv
/home/milamber/temp/jmetertemp/bin/testfiles/HTMLParserTestFile_2.csv
2c2
< Download embedded,200,*Embedded resource download error*,Thread Group
1-1,text,true,,90110,1,1,file:testfiles/HTMLParserTestFile_2.html,,0,UTF-8,1,0
---
> Download embedded,200,OK,Thread Group
1-1,text,true,,90110,1,1,file:testfiles/HTMLParserTestFile_2.html,,0,UTF-8,1,0
Manual execution of HTMLParserTestFile_2.jmx don't show error with
embedded resources (all are retrieve with success) but with the
testfiles/HTMLParserTestFile_2_files/halfbanner.htm has mark with
"Embedded resource download error"
On 22/03/2015 14:04, pmouawad@apache.org wrote:
> Author: pmouawad
> Date: Sun Mar 22 14:04:11 2015
> New Revision: 1668373
>
> URL: http://svn.apache.org/r1668373
> Log:
> Bug 57696 - HTTP Request : Improve responseMessage when resource download fails
> Bugzilla Id: 57696
>
> Modified:
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
> jmeter/trunk/xdocs/changes.xml
>
> Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java?rev=1668373&r1=1668372&r2=1668373&view=diff
> ==============================================================================
> --- jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java (original)
> +++ jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java Sun Mar 22 14:04:11 2015
> @@ -1383,6 +1383,7 @@ public abstract class HTTPSamplerBase ex
> private void setParentSampleSuccess(HTTPSampleResult res, boolean initialValue) {
> if(!IGNORE_FAILED_EMBEDDED_RESOURCES) {
> res.setSuccessful(initialValue);
> + res.setResponseMessage("Embedded resource download error"); //$NON-NLS-1$
> }
> }
>
>
> Modified: jmeter/trunk/xdocs/changes.xml
> URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1668373&r1=1668372&r2=1668373&view=diff
> ==============================================================================
> --- jmeter/trunk/xdocs/changes.xml (original)
> +++ jmeter/trunk/xdocs/changes.xml Sun Mar 22 14:04:11 2015
> @@ -77,6 +77,7 @@ Summary
>
> <h3>HTTP Samplers and Test Script Recorder</h3>
> <ul>
> + <li><bug>57696</bug>HTTP Request : Improve responseMessage when resource download fails. Contributed by Ubik Load Pack (support at ubikloadpack.com)</li>
> </ul>
>
> <h3>Other samplers</h3>
> @@ -153,7 +154,7 @@ Summary
> <ch_section>Thanks</ch_section>
> <p>We thank all contributors mentioned in bug and improvement sections above:
> <ul>
> -
> +<li><a href="http://ubikloadpack.com">Ubik Load Pack</a></li>
> </ul>
>
> <br/>
>
>
>
Re: svn commit: r1668373 - in /jmeter/trunk: src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
xdocs/changes.xml
Posted by Philippe Mouawad <ph...@gmail.com>.
Hi Milamber,
Fixed now.
Thanks
On Sun, Mar 22, 2015 at 5:54 PM, Milamber <mi...@apache.org> wrote:
>
> This commit brings an issue:
>
> batchtest:
> [echo] Starting HTMLParserTestFile_2 using -X
> [jmeter] Creating summariser <summary>
> [jmeter] Created the tree successfully using
> testfiles/HTMLParserTestFile_2.jmx
> [jmeter] Starting the test @ Sun Mar 22 16:39:37 WET 2015
> (1427042377663)
> [jmeter] Waiting for possible shutdown message on port 4445
> [jmeter] summary = 1 in 0.3s = 4.0/s Avg: 173 Min: 173
> Max: 173 Err: 0 (0.00%)
> [jmeter] Tidying up ... @ Sun Mar 22 16:39:38 WET 2015
> (1427042378328)
> [jmeter] ... end of run
>
> BUILD FAILED
> /home/milamber/temp/jmetertemp/build.xml:2563: The following error
> occurred while executing this line:
> /home/milamber/temp/jmetertemp/build.xml:2531: CSV Files are not identical.
>
> /home/milamber/temp/jmetertemp/bin/testfiles/HTMLParserTestFile_2.csv
> /home/milamber/temp/jmetertemp/bin/HTMLParserTestFile_2.csv
>
> Total time: 3 minutes 52 seconds
> milamber@ender:~/temp/jmetertemp$ diff
> /home/milamber/temp/jmetertemp/bin/HTMLParserTestFile_2.csv
> /home/milamber/temp/jmetertemp/bin/testfiles/HTMLParserTestFile_2.csv
> 2c2
> < Download embedded,200,*Embedded resource download error*,Thread Group
>
> 1-1,text,true,,90110,1,1,file:testfiles/HTMLParserTestFile_2.html,,0,UTF-8,1,0
> ---
> > Download embedded,200,OK,Thread Group
>
> 1-1,text,true,,90110,1,1,file:testfiles/HTMLParserTestFile_2.html,,0,UTF-8,1,0
>
>
>
> Manual execution of HTMLParserTestFile_2.jmx don't show error with
> embedded resources (all are retrieve with success) but with the
> testfiles/HTMLParserTestFile_2_files/halfbanner.htm has mark with
> "Embedded resource download error"
>
>
>
>
>
> On 22/03/2015 14:04, pmouawad@apache.org wrote:
> > Author: pmouawad
> > Date: Sun Mar 22 14:04:11 2015
> > New Revision: 1668373
> >
> > URL: http://svn.apache.org/r1668373
> > Log:
> > Bug 57696 - HTTP Request : Improve responseMessage when resource
> download fails
> > Bugzilla Id: 57696
> >
> > Modified:
> >
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
> > jmeter/trunk/xdocs/changes.xml
> >
> > Modified:
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
> > URL:
> http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java?rev=1668373&r1=1668372&r2=1668373&view=diff
> >
> ==============================================================================
> > ---
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
> (original)
> > +++
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
> Sun Mar 22 14:04:11 2015
> > @@ -1383,6 +1383,7 @@ public abstract class HTTPSamplerBase ex
> > private void setParentSampleSuccess(HTTPSampleResult res, boolean
> initialValue) {
> > if(!IGNORE_FAILED_EMBEDDED_RESOURCES) {
> > res.setSuccessful(initialValue);
> > + res.setResponseMessage("Embedded resource download error");
> //$NON-NLS-1$
> > }
> > }
> >
> >
> > Modified: jmeter/trunk/xdocs/changes.xml
> > URL:
> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1668373&r1=1668372&r2=1668373&view=diff
> >
> ==============================================================================
> > --- jmeter/trunk/xdocs/changes.xml (original)
> > +++ jmeter/trunk/xdocs/changes.xml Sun Mar 22 14:04:11 2015
> > @@ -77,6 +77,7 @@ Summary
> >
> > <h3>HTTP Samplers and Test Script Recorder</h3>
> > <ul>
> > + <li><bug>57696</bug>HTTP Request : Improve responseMessage when
> resource download fails. Contributed by Ubik Load Pack (support at
> ubikloadpack.com)</li>
> > </ul>
> >
> > <h3>Other samplers</h3>
> > @@ -153,7 +154,7 @@ Summary
> > <ch_section>Thanks</ch_section>
> > <p>We thank all contributors mentioned in bug and improvement sections
> above:
> > <ul>
> > -
> > +<li><a href="http://ubikloadpack.com">Ubik Load Pack</a></li>
> > </ul>
> >
> > <br/>
> >
> >
> >
>
>
--
Cordialement.
Philippe Mouawad.