You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/04/22 08:25:24 UTC

[GitHub] [kafka] mimaison commented on a diff in pull request #12046: KAFKA-10360: Allow disabling JMX Reporter (KIP-830)

mimaison commented on code in PR #12046:
URL: https://github.com/apache/kafka/pull/12046#discussion_r855922918


##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -331,7 +331,7 @@ public class KafkaAdminClient extends AdminClient {
     /**
      * The name of this AdminClient instance.
      */
-    private final String clientId;
+    final String clientId;

Review Comment:
   Hi @clolov Thanks for taking a look.
   No there is no good reason to do so. This PR is just a draft for now till the KIP gets approved.
   I think instead of making the field package private, we should probably add a new package private method `getClientId()` like we have in `KafkaProducer` and `KafkaConsumer`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org