[GitHub] [daffodil] mbeckerle commented on a diff in pull request #978: Appease scalafmt with extraneous comma

["mbeckerle (via GitHub)" <gi...@apache.org>]

mbeckerle commented on code in PR #978:
URL: https://github.com/apache/daffodil/pull/978#discussion_r1124443668


##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/GroupDef.scala:
##########
@@ -141,7 +141,7 @@ sealed abstract class GlobalGroupDef(
     if (dais.nonEmpty)
       SDW(
         WarnID.InvalidAnnotationPoint,
-        "Annotations placed directly on a group definition will be ignored by DFDL. Any annotation expected to be processed by DFDL should instead be placed on the group reference, sequence or choice."
+        "Annotations placed directly on a group definition will be ignored by DFDL. Any annotation expected to be processed by DFDL should instead be placed on the group reference, sequence or choice.",

Review Comment:
   If this comma is truly required, then our scalafmt rules are wrong.
   
   This comma should be tolerated, ... maybe... but not required. 
   
   This is not a list, it's the arguments to a function call. They are fundamentally different concepts that only occasionally overlap. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org