You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Robert Scholte (JIRA)" <ji...@apache.org> on 2016/01/09 17:32:39 UTC

[jira] [Created] (MDEPLOY-205) MavenProject with only attachments must have packaging "pom"

Robert Scholte created MDEPLOY-205:
--------------------------------------

             Summary: MavenProject with only attachments must have packaging "pom"
                 Key: MDEPLOY-205
                 URL: https://issues.apache.org/jira/browse/MDEPLOY-205
             Project: Maven Deploy Plugin
          Issue Type: Improvement
            Reporter: Robert Scholte
            Assignee: Robert Scholte
             Fix For: 3.0


According to {{svn blame}} MDEPLOY-78 is responsible for this piece of code:
{code}
if ( isPomArtifact )
            {
                deployableArtifacts.add( artifact );
            }
            else
            {
                File file = artifact.getFile();

                if ( file != null && file.isFile() )
                {
                    deployableArtifacts.add( artifact );
                }
                else if ( !attachedArtifacts.isEmpty() )
                {
                    getLog().info( "No primary artifact to deploy, deploying attached artifacts instead." );

                    Artifact pomArtifact =
                        artifactFactory.createProjectArtifact( artifact.getGroupId(), artifact.getArtifactId(),
                                                               artifact.getBaseVersion() );
                    pomArtifact.setFile( pomFile );
                    if ( request.isUpdateReleaseInfo() )
                    {
                        pomArtifact.setRelease( true );
                    }

                    deployableArtifacts.add( pomArtifact );

                    // propagate the timestamped version to the main artifact for the attached artifacts to pick it up
                    artifact.setResolvedVersion( pomArtifact.getVersion() );
                }
                else
                {
                    String message = "The packaging for this project did not assign a file to the build artifact";
                    throw new MojoExecutionException( message );
                }
            }
{code}

I don't like the {{else if}}-clause. IMHO if there's no main artifact, the packaging should simply be 'pom'.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [DISCUSS] MDEPLOY-205: MavenProject with only attachments must have packaging "pom"

Posted by Robert Scholte <rf...@apache.org>.
Op Sun, 10 Jan 2016 17:14:03 +0100 schreef Hervé BOUTEMY  
<he...@free.fr>:

> perhaps there are artifacts in central, that are not built with Maven and
> don't have corresponding Maven artifact handlers
>
> but I suppose this check is only when maven-deploy-plugin will deploy to  
> a
> repo, isn't it?

Indeed, and I expect the same mechanism for the maven-install-plugin. If  
so, that needs to be changed too.

>
> When a project is built with Maven, this requirement of having one main
> artifact (and not only attachements) seems reasonable to me
>
> Regards,
>
> Hervé
>
> Le samedi 9 janvier 2016 19:34:37 Robert Scholte a écrit :
>> that's all handled by the ArtifactHandler, which knows how to translate
>> the packaging and type to a specific file extension.
>> So let me rephrase: in my opinion a non-pom MavenProject MUST have a  
>> main
>> artifact.
>>
>> Regarding the integration tests, to me they abuse the lifecycle for a
>> specific the packaging, for instance to get compiled classes, which are
>> than used as attachment.
>> None of the IT's contain a valid real world example.
>>
>> thanks,
>> Robert
>>
>> Op Sat, 09 Jan 2016 19:11:28 +0100 schreef Dan Tran <da...@gmail.com>:
>> > what about packaging=bundle?  it has jar extension
>> >
>> > -D
>> >
>> > On Sat, Jan 9, 2016 at 9:04 AM, Robert Scholte <rf...@apache.org>
>> >
>> > wrote:
>> >> Hi,
>> >>
>> >> I've created MDEPLOY-205: MavenProject with only attachments must  
>> have
>> >> packaging "pom"[1]
>> >>
>> >> If I apply such a change, tests written for MDEPLOY-45 and MDEPLOY-78
>> >> fail.
>> >>
>> >> [ERROR] The following builds failed:
>> >> [ERROR] *  mdeploy-45-test\pom.xml
>> >> [ERROR] *  no-main-artifact-1\pom.xml
>> >> [ERROR] *  no-main-artifact-2\pom.xml
>> >> [ERROR] *  no-main-artifact-snapshot\pom.xml
>> >>
>> >> Original titles:
>> >> MDEPLOY-45: Classifier not supported by deploy:deploy [2]
>> >> MDEPLOY-78: Deploy with classifier does not deploy pom [3]
>> >>
>> >> Both sound valid as long *as the packaging is pom*
>> >> For the hygiene of the repository if the packaging says jar there  
>> should
>> >> always an artifactId-version.jar
>> >>
>> >> Anyone wants to convince me that I'm wrong?
>> >>
>> >> thanks,
>> >> Robert
>> >>
>> >> [1] https://issues.apache.org/jira/browse/MDEPLOY-205
>> >> [2] https://issues.apache.org/jira/browse/MDEPLOY-45
>> >> [3] https://issues.apache.org/jira/browse/MDEPLOY-78
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> >> For additional commands, e-mail: dev-help@maven.apache.org
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: [DISCUSS] MDEPLOY-205: MavenProject with only attachments must have packaging "pom"

Posted by Hervé BOUTEMY <he...@free.fr>.
perhaps there are artifacts in central, that are not built with Maven and 
don't have corresponding Maven artifact handlers

but I suppose this check is only when maven-deploy-plugin will deploy to a 
repo, isn't it?

When a project is built with Maven, this requirement of having one main 
artifact (and not only attachements) seems reasonable to me

Regards,

Hervé

Le samedi 9 janvier 2016 19:34:37 Robert Scholte a écrit :
> that's all handled by the ArtifactHandler, which knows how to translate
> the packaging and type to a specific file extension.
> So let me rephrase: in my opinion a non-pom MavenProject MUST have a main
> artifact.
> 
> Regarding the integration tests, to me they abuse the lifecycle for a
> specific the packaging, for instance to get compiled classes, which are
> than used as attachment.
> None of the IT's contain a valid real world example.
> 
> thanks,
> Robert
> 
> Op Sat, 09 Jan 2016 19:11:28 +0100 schreef Dan Tran <da...@gmail.com>:
> > what about packaging=bundle?  it has jar extension
> > 
> > -D
> > 
> > On Sat, Jan 9, 2016 at 9:04 AM, Robert Scholte <rf...@apache.org>
> > 
> > wrote:
> >> Hi,
> >> 
> >> I've created MDEPLOY-205: MavenProject with only attachments must have
> >> packaging "pom"[1]
> >> 
> >> If I apply such a change, tests written for MDEPLOY-45 and MDEPLOY-78
> >> fail.
> >> 
> >> [ERROR] The following builds failed:
> >> [ERROR] *  mdeploy-45-test\pom.xml
> >> [ERROR] *  no-main-artifact-1\pom.xml
> >> [ERROR] *  no-main-artifact-2\pom.xml
> >> [ERROR] *  no-main-artifact-snapshot\pom.xml
> >> 
> >> Original titles:
> >> MDEPLOY-45: Classifier not supported by deploy:deploy [2]
> >> MDEPLOY-78: Deploy with classifier does not deploy pom [3]
> >> 
> >> Both sound valid as long *as the packaging is pom*
> >> For the hygiene of the repository if the packaging says jar there should
> >> always an artifactId-version.jar
> >> 
> >> Anyone wants to convince me that I'm wrong?
> >> 
> >> thanks,
> >> Robert
> >> 
> >> [1] https://issues.apache.org/jira/browse/MDEPLOY-205
> >> [2] https://issues.apache.org/jira/browse/MDEPLOY-45
> >> [3] https://issues.apache.org/jira/browse/MDEPLOY-78
> >> 
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: [DISCUSS] MDEPLOY-205: MavenProject with only attachments must have packaging "pom"

Posted by Dan Tran <da...@gmail.com>.
+1 to introduce this policy which surely reduce the confusion of packaging
type during deploy:deploy-file

-D

On Sat, Jan 9, 2016 at 10:34 AM, Robert Scholte <rf...@apache.org>
wrote:

> that's all handled by the ArtifactHandler, which knows how to translate
> the packaging and type to a specific file extension.
> So let me rephrase: in my opinion a non-pom MavenProject MUST have a main
> artifact.
>
> Regarding the integration tests, to me they abuse the lifecycle for a
> specific the packaging, for instance to get compiled classes, which are
> than used as attachment.
> None of the IT's contain a valid real world example.
>
> thanks,
> Robert
>
>
> Op Sat, 09 Jan 2016 19:11:28 +0100 schreef Dan Tran <da...@gmail.com>:
>
>
> what about packaging=bundle?  it has jar extension
>>
>> -D
>>
>> On Sat, Jan 9, 2016 at 9:04 AM, Robert Scholte <rf...@apache.org>
>> wrote:
>>
>> Hi,
>>>
>>> I've created MDEPLOY-205: MavenProject with only attachments must have
>>> packaging "pom"[1]
>>>
>>> If I apply such a change, tests written for MDEPLOY-45 and MDEPLOY-78
>>> fail.
>>>
>>> [ERROR] The following builds failed:
>>> [ERROR] *  mdeploy-45-test\pom.xml
>>> [ERROR] *  no-main-artifact-1\pom.xml
>>> [ERROR] *  no-main-artifact-2\pom.xml
>>> [ERROR] *  no-main-artifact-snapshot\pom.xml
>>>
>>> Original titles:
>>> MDEPLOY-45: Classifier not supported by deploy:deploy [2]
>>> MDEPLOY-78: Deploy with classifier does not deploy pom [3]
>>>
>>> Both sound valid as long *as the packaging is pom*
>>> For the hygiene of the repository if the packaging says jar there should
>>> always an artifactId-version.jar
>>>
>>> Anyone wants to convince me that I'm wrong?
>>>
>>> thanks,
>>> Robert
>>>
>>> [1] https://issues.apache.org/jira/browse/MDEPLOY-205
>>> [2] https://issues.apache.org/jira/browse/MDEPLOY-45
>>> [3] https://issues.apache.org/jira/browse/MDEPLOY-78
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: [DISCUSS] MDEPLOY-205: MavenProject with only attachments must have packaging "pom"

Posted by Robert Scholte <rf...@apache.org>.
Hi Tibor,

no need to debug, I can read (and do understand) what's happening and IMHO  
those tests are not reasonable.
Of course I'm aware that some IT are simplified versions just for testing  
purpose, but why would anyone create a war-project without the war (only  
as attachment)?
All I'm looking for is an explanation for this behavior, otherwise I'm  
going to change it to the way everybody expect Maven to work.

thanks,
Robert

Op Sun, 10 Jan 2016 12:08:48 +0100 schreef Tibor Digana  
<ti...@googlemail.com>:

> Even if they are not real world ITs they are reasonable tests.
> Did you debug the plugin?
> In cases like this I am always debugging the code.
>
> On Sat, Jan 9, 2016 at 7:34 PM, Robert Scholte <rf...@apache.org>  
> wrote:
>
>> that's all handled by the ArtifactHandler, which knows how to translate
>> the packaging and type to a specific file extension.
>> So let me rephrase: in my opinion a non-pom MavenProject MUST have a  
>> main
>> artifact.
>>
>> Regarding the integration tests, to me they abuse the lifecycle for a
>> specific the packaging, for instance to get compiled classes, which are
>> than used as attachment.
>> None of the IT's contain a valid real world example.
>>
>> thanks,
>> Robert
>>
>>
>> Op Sat, 09 Jan 2016 19:11:28 +0100 schreef Dan Tran <da...@gmail.com>:
>>
>>
>> what about packaging=bundle?  it has jar extension
>>>
>>> -D
>>>
>>> On Sat, Jan 9, 2016 at 9:04 AM, Robert Scholte <rf...@apache.org>
>>> wrote:
>>>
>>> Hi,
>>>>
>>>> I've created MDEPLOY-205: MavenProject with only attachments must have
>>>> packaging "pom"[1]
>>>>
>>>> If I apply such a change, tests written for MDEPLOY-45 and MDEPLOY-78
>>>> fail.
>>>>
>>>> [ERROR] The following builds failed:
>>>> [ERROR] *  mdeploy-45-test\pom.xml
>>>> [ERROR] *  no-main-artifact-1\pom.xml
>>>> [ERROR] *  no-main-artifact-2\pom.xml
>>>> [ERROR] *  no-main-artifact-snapshot\pom.xml
>>>>
>>>> Original titles:
>>>> MDEPLOY-45: Classifier not supported by deploy:deploy [2]
>>>> MDEPLOY-78: Deploy with classifier does not deploy pom [3]
>>>>
>>>> Both sound valid as long *as the packaging is pom*
>>>> For the hygiene of the repository if the packaging says jar there  
>>>> should
>>>> always an artifactId-version.jar
>>>>
>>>> Anyone wants to convince me that I'm wrong?
>>>>
>>>> thanks,
>>>> Robert
>>>>
>>>> [1] https://issues.apache.org/jira/browse/MDEPLOY-205
>>>> [2] https://issues.apache.org/jira/browse/MDEPLOY-45
>>>> [3] https://issues.apache.org/jira/browse/MDEPLOY-78
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: [DISCUSS] MDEPLOY-205: MavenProject with only attachments must have packaging "pom"

Posted by Tibor Digana <ti...@googlemail.com>.
Even if they are not real world ITs they are reasonable tests.
Did you debug the plugin?
In cases like this I am always debugging the code.

On Sat, Jan 9, 2016 at 7:34 PM, Robert Scholte <rf...@apache.org> wrote:

> that's all handled by the ArtifactHandler, which knows how to translate
> the packaging and type to a specific file extension.
> So let me rephrase: in my opinion a non-pom MavenProject MUST have a main
> artifact.
>
> Regarding the integration tests, to me they abuse the lifecycle for a
> specific the packaging, for instance to get compiled classes, which are
> than used as attachment.
> None of the IT's contain a valid real world example.
>
> thanks,
> Robert
>
>
> Op Sat, 09 Jan 2016 19:11:28 +0100 schreef Dan Tran <da...@gmail.com>:
>
>
> what about packaging=bundle?  it has jar extension
>>
>> -D
>>
>> On Sat, Jan 9, 2016 at 9:04 AM, Robert Scholte <rf...@apache.org>
>> wrote:
>>
>> Hi,
>>>
>>> I've created MDEPLOY-205: MavenProject with only attachments must have
>>> packaging "pom"[1]
>>>
>>> If I apply such a change, tests written for MDEPLOY-45 and MDEPLOY-78
>>> fail.
>>>
>>> [ERROR] The following builds failed:
>>> [ERROR] *  mdeploy-45-test\pom.xml
>>> [ERROR] *  no-main-artifact-1\pom.xml
>>> [ERROR] *  no-main-artifact-2\pom.xml
>>> [ERROR] *  no-main-artifact-snapshot\pom.xml
>>>
>>> Original titles:
>>> MDEPLOY-45: Classifier not supported by deploy:deploy [2]
>>> MDEPLOY-78: Deploy with classifier does not deploy pom [3]
>>>
>>> Both sound valid as long *as the packaging is pom*
>>> For the hygiene of the repository if the packaging says jar there should
>>> always an artifactId-version.jar
>>>
>>> Anyone wants to convince me that I'm wrong?
>>>
>>> thanks,
>>> Robert
>>>
>>> [1] https://issues.apache.org/jira/browse/MDEPLOY-205
>>> [2] https://issues.apache.org/jira/browse/MDEPLOY-45
>>> [3] https://issues.apache.org/jira/browse/MDEPLOY-78
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>


-- 
Cheers
Tibor

Re: [DISCUSS] MDEPLOY-205: MavenProject with only attachments must have packaging "pom"

Posted by Robert Scholte <rf...@apache.org>.
that's all handled by the ArtifactHandler, which knows how to translate  
the packaging and type to a specific file extension.
So let me rephrase: in my opinion a non-pom MavenProject MUST have a main  
artifact.

Regarding the integration tests, to me they abuse the lifecycle for a  
specific the packaging, for instance to get compiled classes, which are  
than used as attachment.
None of the IT's contain a valid real world example.

thanks,
Robert


Op Sat, 09 Jan 2016 19:11:28 +0100 schreef Dan Tran <da...@gmail.com>:

> what about packaging=bundle?  it has jar extension
>
> -D
>
> On Sat, Jan 9, 2016 at 9:04 AM, Robert Scholte <rf...@apache.org>  
> wrote:
>
>> Hi,
>>
>> I've created MDEPLOY-205: MavenProject with only attachments must have
>> packaging "pom"[1]
>>
>> If I apply such a change, tests written for MDEPLOY-45 and MDEPLOY-78  
>> fail.
>>
>> [ERROR] The following builds failed:
>> [ERROR] *  mdeploy-45-test\pom.xml
>> [ERROR] *  no-main-artifact-1\pom.xml
>> [ERROR] *  no-main-artifact-2\pom.xml
>> [ERROR] *  no-main-artifact-snapshot\pom.xml
>>
>> Original titles:
>> MDEPLOY-45: Classifier not supported by deploy:deploy [2]
>> MDEPLOY-78: Deploy with classifier does not deploy pom [3]
>>
>> Both sound valid as long *as the packaging is pom*
>> For the hygiene of the repository if the packaging says jar there should
>> always an artifactId-version.jar
>>
>> Anyone wants to convince me that I'm wrong?
>>
>> thanks,
>> Robert
>>
>> [1] https://issues.apache.org/jira/browse/MDEPLOY-205
>> [2] https://issues.apache.org/jira/browse/MDEPLOY-45
>> [3] https://issues.apache.org/jira/browse/MDEPLOY-78
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: [DISCUSS] MDEPLOY-205: MavenProject with only attachments must have packaging "pom"

Posted by Dan Tran <da...@gmail.com>.
what about packaging=bundle?  it has jar extension

-D

On Sat, Jan 9, 2016 at 9:04 AM, Robert Scholte <rf...@apache.org> wrote:

> Hi,
>
> I've created MDEPLOY-205: MavenProject with only attachments must have
> packaging "pom"[1]
>
> If I apply such a change, tests written for MDEPLOY-45 and MDEPLOY-78 fail.
>
> [ERROR] The following builds failed:
> [ERROR] *  mdeploy-45-test\pom.xml
> [ERROR] *  no-main-artifact-1\pom.xml
> [ERROR] *  no-main-artifact-2\pom.xml
> [ERROR] *  no-main-artifact-snapshot\pom.xml
>
> Original titles:
> MDEPLOY-45: Classifier not supported by deploy:deploy [2]
> MDEPLOY-78: Deploy with classifier does not deploy pom [3]
>
> Both sound valid as long *as the packaging is pom*
> For the hygiene of the repository if the packaging says jar there should
> always an artifactId-version.jar
>
> Anyone wants to convince me that I'm wrong?
>
> thanks,
> Robert
>
> [1] https://issues.apache.org/jira/browse/MDEPLOY-205
> [2] https://issues.apache.org/jira/browse/MDEPLOY-45
> [3] https://issues.apache.org/jira/browse/MDEPLOY-78
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: [DISCUSS] MDEPLOY-205: MavenProject with only attachments must have packaging "pom"

Posted by Arnaud Héritier <ah...@gmail.com>.
+1

On Tue, Jan 12, 2016 at 8:25 PM, Bing Shiao <bi...@gmail.com> wrote:

> +1
> On Jan 12, 2016 11:05 AM, "Dennis Lundberg" <de...@gmail.com>
> wrote:
>
> > +1
> > Den 11 jan 2016 22:37 skrev "Robert Scholte" <rf...@apache.org>:
> >
> > > this might be the root cause:
> > >
> > > MINSTALL-41 [1]:
> > > I have a project wich I need to build only specifying a classifier (in
> > > detail: a war project which I need to build with different profiles to
> > > include different
> > >  configurations. So I set up different filters and the package produces
> > > different classified wars).
> > >
> > > So IMHO abuse of profiles, not a reason to support attachments without
> a
> > > main artifact when packaging is 'war'.
> > > Instead I would suggest extracting the configuration or if one *really*
> > > wants to include configuration: use overlays per environment.
> > >
> > > thanks,
> > > Robert
> > >
> > > [1] https://issues.apache.org/jira/browse/MINSTALL-41
> > >
> > > Op Sat, 09 Jan 2016 18:04:40 +0100 schreef Robert Scholte <
> > > rfscholte@apache.org>:
> > >
> > > Hi,
> > >>
> > >> I've created MDEPLOY-205: MavenProject with only attachments must have
> > >> packaging "pom"[1]
> > >>
> > >> If I apply such a change, tests written for MDEPLOY-45 and MDEPLOY-78
> > >> fail.
> > >>
> > >> [ERROR] The following builds failed:
> > >> [ERROR] *  mdeploy-45-test\pom.xml
> > >> [ERROR] *  no-main-artifact-1\pom.xml
> > >> [ERROR] *  no-main-artifact-2\pom.xml
> > >> [ERROR] *  no-main-artifact-snapshot\pom.xml
> > >>
> > >> Original titles:
> > >> MDEPLOY-45: Classifier not supported by deploy:deploy [2]
> > >> MDEPLOY-78: Deploy with classifier does not deploy pom [3]
> > >>
> > >> Both sound valid as long *as the packaging is pom*
> > >> For the hygiene of the repository if the packaging says jar there
> should
> > >> always an artifactId-version.jar
> > >>
> > >> Anyone wants to convince me that I'm wrong?
> > >>
> > >> thanks,
> > >> Robert
> > >>
> > >> [1] https://issues.apache.org/jira/browse/MDEPLOY-205
> > >> [2] https://issues.apache.org/jira/browse/MDEPLOY-45
> > >> [3] https://issues.apache.org/jira/browse/MDEPLOY-78
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >> For additional commands, e-mail: dev-help@maven.apache.org
> > >>
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
> > >
> > >
> >
>



-- 
-----
Arnaud Héritier
http://aheritier.net
Mail/GTalk: aheritier AT gmail DOT com
Twitter/Skype : aheritier

Re: [DISCUSS] MDEPLOY-205: MavenProject with only attachments must have packaging "pom"

Posted by Bing Shiao <bi...@gmail.com>.
+1
On Jan 12, 2016 11:05 AM, "Dennis Lundberg" <de...@gmail.com>
wrote:

> +1
> Den 11 jan 2016 22:37 skrev "Robert Scholte" <rf...@apache.org>:
>
> > this might be the root cause:
> >
> > MINSTALL-41 [1]:
> > I have a project wich I need to build only specifying a classifier (in
> > detail: a war project which I need to build with different profiles to
> > include different
> >  configurations. So I set up different filters and the package produces
> > different classified wars).
> >
> > So IMHO abuse of profiles, not a reason to support attachments without a
> > main artifact when packaging is 'war'.
> > Instead I would suggest extracting the configuration or if one *really*
> > wants to include configuration: use overlays per environment.
> >
> > thanks,
> > Robert
> >
> > [1] https://issues.apache.org/jira/browse/MINSTALL-41
> >
> > Op Sat, 09 Jan 2016 18:04:40 +0100 schreef Robert Scholte <
> > rfscholte@apache.org>:
> >
> > Hi,
> >>
> >> I've created MDEPLOY-205: MavenProject with only attachments must have
> >> packaging "pom"[1]
> >>
> >> If I apply such a change, tests written for MDEPLOY-45 and MDEPLOY-78
> >> fail.
> >>
> >> [ERROR] The following builds failed:
> >> [ERROR] *  mdeploy-45-test\pom.xml
> >> [ERROR] *  no-main-artifact-1\pom.xml
> >> [ERROR] *  no-main-artifact-2\pom.xml
> >> [ERROR] *  no-main-artifact-snapshot\pom.xml
> >>
> >> Original titles:
> >> MDEPLOY-45: Classifier not supported by deploy:deploy [2]
> >> MDEPLOY-78: Deploy with classifier does not deploy pom [3]
> >>
> >> Both sound valid as long *as the packaging is pom*
> >> For the hygiene of the repository if the packaging says jar there should
> >> always an artifactId-version.jar
> >>
> >> Anyone wants to convince me that I'm wrong?
> >>
> >> thanks,
> >> Robert
> >>
> >> [1] https://issues.apache.org/jira/browse/MDEPLOY-205
> >> [2] https://issues.apache.org/jira/browse/MDEPLOY-45
> >> [3] https://issues.apache.org/jira/browse/MDEPLOY-78
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>

Re: [DISCUSS] MDEPLOY-205: MavenProject with only attachments must have packaging "pom"

Posted by Dennis Lundberg <de...@gmail.com>.
+1
Den 11 jan 2016 22:37 skrev "Robert Scholte" <rf...@apache.org>:

> this might be the root cause:
>
> MINSTALL-41 [1]:
> I have a project wich I need to build only specifying a classifier (in
> detail: a war project which I need to build with different profiles to
> include different
>  configurations. So I set up different filters and the package produces
> different classified wars).
>
> So IMHO abuse of profiles, not a reason to support attachments without a
> main artifact when packaging is 'war'.
> Instead I would suggest extracting the configuration or if one *really*
> wants to include configuration: use overlays per environment.
>
> thanks,
> Robert
>
> [1] https://issues.apache.org/jira/browse/MINSTALL-41
>
> Op Sat, 09 Jan 2016 18:04:40 +0100 schreef Robert Scholte <
> rfscholte@apache.org>:
>
> Hi,
>>
>> I've created MDEPLOY-205: MavenProject with only attachments must have
>> packaging "pom"[1]
>>
>> If I apply such a change, tests written for MDEPLOY-45 and MDEPLOY-78
>> fail.
>>
>> [ERROR] The following builds failed:
>> [ERROR] *  mdeploy-45-test\pom.xml
>> [ERROR] *  no-main-artifact-1\pom.xml
>> [ERROR] *  no-main-artifact-2\pom.xml
>> [ERROR] *  no-main-artifact-snapshot\pom.xml
>>
>> Original titles:
>> MDEPLOY-45: Classifier not supported by deploy:deploy [2]
>> MDEPLOY-78: Deploy with classifier does not deploy pom [3]
>>
>> Both sound valid as long *as the packaging is pom*
>> For the hygiene of the repository if the packaging says jar there should
>> always an artifactId-version.jar
>>
>> Anyone wants to convince me that I'm wrong?
>>
>> thanks,
>> Robert
>>
>> [1] https://issues.apache.org/jira/browse/MDEPLOY-205
>> [2] https://issues.apache.org/jira/browse/MDEPLOY-45
>> [3] https://issues.apache.org/jira/browse/MDEPLOY-78
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: [DISCUSS] MDEPLOY-205: MavenProject with only attachments must have packaging "pom"

Posted by Stephen Connolly <st...@gmail.com>.
+1

On 11 January 2016 at 21:37, Robert Scholte <rf...@apache.org> wrote:

> this might be the root cause:
>
> MINSTALL-41 [1]:
> I have a project wich I need to build only specifying a classifier (in
> detail: a war project which I need to build with different profiles to
> include different
>  configurations. So I set up different filters and the package produces
> different classified wars).
>
> So IMHO abuse of profiles, not a reason to support attachments without a
> main artifact when packaging is 'war'.
> Instead I would suggest extracting the configuration or if one *really*
> wants to include configuration: use overlays per environment.
>
> thanks,
> Robert
>
> [1] https://issues.apache.org/jira/browse/MINSTALL-41
>
> Op Sat, 09 Jan 2016 18:04:40 +0100 schreef Robert Scholte <
> rfscholte@apache.org>:
>
>
> Hi,
>>
>> I've created MDEPLOY-205: MavenProject with only attachments must have
>> packaging "pom"[1]
>>
>> If I apply such a change, tests written for MDEPLOY-45 and MDEPLOY-78
>> fail.
>>
>> [ERROR] The following builds failed:
>> [ERROR] *  mdeploy-45-test\pom.xml
>> [ERROR] *  no-main-artifact-1\pom.xml
>> [ERROR] *  no-main-artifact-2\pom.xml
>> [ERROR] *  no-main-artifact-snapshot\pom.xml
>>
>> Original titles:
>> MDEPLOY-45: Classifier not supported by deploy:deploy [2]
>> MDEPLOY-78: Deploy with classifier does not deploy pom [3]
>>
>> Both sound valid as long *as the packaging is pom*
>> For the hygiene of the repository if the packaging says jar there should
>> always an artifactId-version.jar
>>
>> Anyone wants to convince me that I'm wrong?
>>
>> thanks,
>> Robert
>>
>> [1] https://issues.apache.org/jira/browse/MDEPLOY-205
>> [2] https://issues.apache.org/jira/browse/MDEPLOY-45
>> [3] https://issues.apache.org/jira/browse/MDEPLOY-78
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: [DISCUSS] MDEPLOY-205: MavenProject with only attachments must have packaging "pom"

Posted by Robert Scholte <rf...@apache.org>.
this might be the root cause:

MINSTALL-41 [1]:
I have a project wich I need to build only specifying a classifier (in  
detail: a war project which I need to build with different profiles to  
include different
  configurations. So I set up different filters and the package produces  
different classified wars).

So IMHO abuse of profiles, not a reason to support attachments without a  
main artifact when packaging is 'war'.
Instead I would suggest extracting the configuration or if one *really*  
wants to include configuration: use overlays per environment.

thanks,
Robert

[1] https://issues.apache.org/jira/browse/MINSTALL-41

Op Sat, 09 Jan 2016 18:04:40 +0100 schreef Robert Scholte  
<rf...@apache.org>:

> Hi,
>
> I've created MDEPLOY-205: MavenProject with only attachments must have  
> packaging "pom"[1]
>
> If I apply such a change, tests written for MDEPLOY-45 and MDEPLOY-78  
> fail.
>
> [ERROR] The following builds failed:
> [ERROR] *  mdeploy-45-test\pom.xml
> [ERROR] *  no-main-artifact-1\pom.xml
> [ERROR] *  no-main-artifact-2\pom.xml
> [ERROR] *  no-main-artifact-snapshot\pom.xml
>
> Original titles:
> MDEPLOY-45: Classifier not supported by deploy:deploy [2]
> MDEPLOY-78: Deploy with classifier does not deploy pom [3]
>
> Both sound valid as long *as the packaging is pom*
> For the hygiene of the repository if the packaging says jar there should  
> always an artifactId-version.jar
>
> Anyone wants to convince me that I'm wrong?
>
> thanks,
> Robert
>
> [1] https://issues.apache.org/jira/browse/MDEPLOY-205
> [2] https://issues.apache.org/jira/browse/MDEPLOY-45
> [3] https://issues.apache.org/jira/browse/MDEPLOY-78
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: [DISCUSS] MDEPLOY-205: MavenProject with only attachments must have packaging "pom"

Posted by Robert Scholte <rf...@apache.org>.
Hi all,

thanks for the support, the message is clear.
I'll continue with the implementation.

Robert

Op Sat, 09 Jan 2016 18:04:40 +0100 schreef Robert Scholte  
<rf...@apache.org>:

> Hi,
>
> I've created MDEPLOY-205: MavenProject with only attachments must have  
> packaging "pom"[1]
>
> If I apply such a change, tests written for MDEPLOY-45 and MDEPLOY-78  
> fail.
>
> [ERROR] The following builds failed:
> [ERROR] *  mdeploy-45-test\pom.xml
> [ERROR] *  no-main-artifact-1\pom.xml
> [ERROR] *  no-main-artifact-2\pom.xml
> [ERROR] *  no-main-artifact-snapshot\pom.xml
>
> Original titles:
> MDEPLOY-45: Classifier not supported by deploy:deploy [2]
> MDEPLOY-78: Deploy with classifier does not deploy pom [3]
>
> Both sound valid as long *as the packaging is pom*
> For the hygiene of the repository if the packaging says jar there should  
> always an artifactId-version.jar
>
> Anyone wants to convince me that I'm wrong?
>
> thanks,
> Robert
>
> [1] https://issues.apache.org/jira/browse/MDEPLOY-205
> [2] https://issues.apache.org/jira/browse/MDEPLOY-45
> [3] https://issues.apache.org/jira/browse/MDEPLOY-78
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

[DISCUSS] MDEPLOY-205: MavenProject with only attachments must have packaging "pom"

Posted by Robert Scholte <rf...@apache.org>.
Hi,

I've created MDEPLOY-205: MavenProject with only attachments must have  
packaging "pom"[1]

If I apply such a change, tests written for MDEPLOY-45 and MDEPLOY-78 fail.

[ERROR] The following builds failed:
[ERROR] *  mdeploy-45-test\pom.xml
[ERROR] *  no-main-artifact-1\pom.xml
[ERROR] *  no-main-artifact-2\pom.xml
[ERROR] *  no-main-artifact-snapshot\pom.xml

Original titles:
MDEPLOY-45: Classifier not supported by deploy:deploy [2]
MDEPLOY-78: Deploy with classifier does not deploy pom [3]

Both sound valid as long *as the packaging is pom*
For the hygiene of the repository if the packaging says jar there should  
always an artifactId-version.jar

Anyone wants to convince me that I'm wrong?

thanks,
Robert

[1] https://issues.apache.org/jira/browse/MDEPLOY-205
[2] https://issues.apache.org/jira/browse/MDEPLOY-45
[3] https://issues.apache.org/jira/browse/MDEPLOY-78

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org