You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/25 06:24:15 UTC

[GitHub] [cloudstack] davidjumani opened a new pull request #5368: ui: Fix action bar in place

davidjumani opened a new pull request #5368:
URL: https://github.com/apache/cloudstack/pull/5368


   ### Description
   
   Fixes the action bar in place to prevent scrolling during multi-select 
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   ### Screenshots (if appropriate):
   
   #### Before :
   
   ![Screenshot from 2021-08-25 11-52-36](https://user-images.githubusercontent.com/8244774/130737339-f3a49b84-944a-461f-b214-eba3508ad0cb.png)
   
   #### After : 
   
   ![Screenshot from 2021-08-25 11-52-19](https://user-images.githubusercontent.com/8244774/130737355-2a95778b-1e8a-4cd3-9eef-3591d7677691.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez merged pull request #5368: ui: Fix action bar in place

Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5368:
URL: https://github.com/apache/cloudstack/pull/5368


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez merged pull request #5368: ui: Fix action bar in place

Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5368:
URL: https://github.com/apache/cloudstack/pull/5368


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5368: ui: Fix action bar in place

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5368:
URL: https://github.com/apache/cloudstack/pull/5368#issuecomment-905222596


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5368 (SL-JID-564)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #5368: ui: Fix action bar in place

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5368:
URL: https://github.com/apache/cloudstack/pull/5368#issuecomment-905329485


   @utchoang Is there a better way to do this ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5368: ui: Fix action bar in place

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5368:
URL: https://github.com/apache/cloudstack/pull/5368#issuecomment-907084854


   @davidjumani does this affect 4.15 too? Maybe the floating right thingy can be at bottom-right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5368: ui: Fix action bar in place

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5368:
URL: https://github.com/apache/cloudstack/pull/5368#issuecomment-906134912


   This is good and enough for as far as this issue is concerned, imnsho. As for hiding the action button, I've not seen the need for it yet. Let's deal with it when someone does, @davidjumani .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5368: ui: Fix action bar in place

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5368:
URL: https://github.com/apache/cloudstack/pull/5368#issuecomment-905220505


   @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani removed a comment on pull request #5368: ui: Fix action bar in place

Posted by GitBox <gi...@apache.org>.
davidjumani removed a comment on pull request #5368:
URL: https://github.com/apache/cloudstack/pull/5368#issuecomment-905219962


   This can potentially break mobile view in devices with resolution < 500 px wide
   @utchoang @shwstppr @rhtyd Any suggestions on how to fix it ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #5368: ui: Fix action bar in place

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5368:
URL: https://github.com/apache/cloudstack/pull/5368#issuecomment-906093818


   @utchoang That sounds doable, but it might cover the data fields. @rhtyd @DaanHoogland Any thoughts ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #5368: ui: Fix action bar in place

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5368:
URL: https://github.com/apache/cloudstack/pull/5368#issuecomment-905970048


   @davidjumani I think it's fine. In my opinion, there is another way, as the theme settings button, there will be a button toggle show/hide actions button. What do you think about this?
   ![image](https://user-images.githubusercontent.com/13766648/130881787-ec962ce8-16fb-456a-b12e-a89fc9dcb20c.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #5368: ui: Fix action bar in place

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5368:
URL: https://github.com/apache/cloudstack/pull/5368#issuecomment-905219962


   This can potentially break mobile view in devices with resolution < 500 px wide
   @utchoang @shwstppr @rhtyd Any suggestions on how to fix it ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #5368: ui: Fix action bar in place

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5368:
URL: https://github.com/apache/cloudstack/pull/5368#issuecomment-905220184


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org