You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Syed Albiz <s....@gmail.com> on 2011/08/02 02:55:40 UTC

Review Request: HIVE-2331: Turn off compression when generating index intermediate results

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1254/
-----------------------------------------------------------

Review request for hive and John Sichi.


Summary
-------

add a parameter to the hiveConf when generating the index query to ensure that the output is uncompressed


This addresses bug HIVE-2331.
    https://issues.apache.org/jira/browse/HIVE-2331


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java 8f185be 
  ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java ff9c4cc 
  ql/src/test/queries/clientpositive/index_bitmap_compression.q PRE-CREATION 
  ql/src/test/queries/clientpositive/index_compression.q PRE-CREATION 
  ql/src/test/results/clientpositive/index_bitmap_compression.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/index_compression.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1254/diff


Testing
-------

added index_compression.q and index_bitmap_compression.q to test both index handlers for this case.


Thanks,

Syed


Re: Review Request: HIVE-2331: Turn off compression when generating index intermediate results

Posted by Syed Albiz <s....@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1254/
-----------------------------------------------------------

(Updated 2011-08-02 18:58:32.937434)


Review request for hive and John Sichi.


Changes
-------

Regenerated the testcase outputs since they were mixed up previously.


Summary
-------

add a parameter to the hiveConf when generating the index query to ensure that the output is uncompressed


This addresses bug HIVE-2331.
    https://issues.apache.org/jira/browse/HIVE-2331


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java c93c852 
  ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java f4b7c15 
  ql/src/test/queries/clientpositive/index_bitmap_compression.q PRE-CREATION 
  ql/src/test/queries/clientpositive/index_compression.q PRE-CREATION 
  ql/src/test/results/clientpositive/index_bitmap_compression.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/index_compression.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1254/diff


Testing
-------

added index_compression.q and index_bitmap_compression.q to test both index handlers for this case.


Thanks,

Syed