[GitHub] [jena] afs edited a comment on issue #548: JENA-1689: change type of Polyadic#m_subGraphs from List to Set

[GitBox <gi...@apache.org>]

afs edited a comment on issue #548: JENA-1689: change type of Polyadic#m_subGraphs from List to Set
URL: https://github.com/apache/jena/pull/548#issuecomment-476404449
 
 
   What is the performance issue? Is it because a graph is added two or more times?
   
   MultiUnion.addGraph suppresses duplicate graphs at the point of addition of the graph. Application-written subclasses of Polyadic could do the same.
   
   (graphs are .equals by identity not by value (contents)).
   
       if (!m_subGraphs.contains( graph )) {
                   m_subGraphs.add( graph );
               }
   
   The concern here is that MultiUnion is commonly used, and quite old, so changes risk unexpected effect in existing applications.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services