You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "daeho-ro (via GitHub)" <gi...@apache.org> on 2026/06/01 10:56:04 UTC
[PR] fix: guard SO_BINDTODEVICE (brpc)
daeho-ro opened a new pull request, #3320:
URL: https://github.com/apache/brpc/pull/3320
### What problem does this PR solve?
Issue Number: resolve
Problem Summary: MacOS 14 doesn't have `SO_BINDTODEVICE` and so guard it only if it is defined.
### What is changed and the side effects?
Changed: Check the `SO_BINDTODEVICE` is defined or not.
Side effects:
- Performance effects:
- Breaking backward compatibility:
---
### Check List:
- Please make sure your changes are compilable.
- When providing us with a new feature, it is best to add related tests.
- Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] fix: guard SO_BINDTODEVICE (brpc)
Posted by "chenBright (via GitHub)" <gi...@apache.org>.
chenBright merged PR #3320:
URL: https://github.com/apache/brpc/pull/3320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] fix: guard SO_BINDTODEVICE (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #3320:
URL: https://github.com/apache/brpc/pull/3320#issuecomment-4627684131
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org