You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/05/08 13:49:54 UTC

svn commit: r1889678 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDPageLabels.java

Author: tilman
Date: Sat May  8 13:49:54 2021
New Revision: 1889678

URL: http://svn.apache.org/viewvc?rev=1889678&view=rev
Log:
PDFBOX-4892: optimize, as suggested by valerybokov

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDPageLabels.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDPageLabels.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDPageLabels.java?rev=1889678&r1=1889677&r2=1889678&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDPageLabels.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDPageLabels.java Sat May  8 13:49:54 2021
@@ -99,23 +99,27 @@ public class PDPageLabels implements COS
     
     private void findLabels(PDNumberTreeNode node) throws IOException 
     {
+        List<PDNumberTreeNode> kids = node.getKids();
         if (node.getKids() != null) 
         {
-            List<PDNumberTreeNode> kids = node.getKids();
             for (PDNumberTreeNode kid : kids) 
             {
                 findLabels(kid);
             }
         }
-        else if (node.getNumbers() != null)
+        else
         {
-            node.getNumbers().forEach((key, pageLabelRange) ->
+            Map<Integer,COSObjectable> numbers = node.getNumbers();
+            if (numbers != null)
             {
-                if (key >= 0)
+                numbers.forEach((key, pageLabelRange) ->
                 {
-                    labels.put(key, (PDPageLabelRange) pageLabelRange);
-                }
-            });
+                    if (key >= 0)
+                    {
+                        labels.put(key, (PDPageLabelRange) pageLabelRange);
+                    }
+                });
+            }
         }
     }