[GitHub] [iceberg] ConeyLiu commented on a diff in pull request #8685: Spark: Clean up FileIO instances on executors

["ConeyLiu (via GitHub)" <gi...@apache.org>]

ConeyLiu commented on code in PR #8685:
URL: https://github.com/apache/iceberg/pull/8685#discussion_r1342096724


##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SerializableTableWithSize.java:
##########
@@ -49,6 +61,14 @@ public static Table copyOf(Table table) {
     }
   }
 
+  @Override
+  public void close() throws Exception {
+    if (serializationMarker == null) {
+      LOG.info("Releasing resources");
+      io().close();
+    }
+  }
+
   public static class SerializableMetadataTableWithSize extends SerializableMetadataTable

Review Comment:
   Why not do the same cleanup for `MetadataaTable` as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org