You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/11 16:58:34 UTC
[GitHub] [airflow] kaxil commented on a change in pull request #12990: Changes release image preparation to use PyPI packages
kaxil commented on a change in pull request #12990:
URL: https://github.com/apache/airflow/pull/12990#discussion_r541090036
##########
File path: docs/apache-airflow/production-deployment.rst
##########
@@ -608,59 +610,33 @@ production image. There are three types of build:
* You can build the image from released PyPi airflow package (used to build the official Docker image)
* You can build the image from any version in GitHub repository(this is used mostly for system testing).
-+-----------------------------------+-----------------------------------+
-| Build argument | What to specify |
-+===================================+===================================+
-| ``AIRFLOW_INSTALL_SOURCES`` | Should point to the sources of |
-| | of Apache Airflow. It can be |
-| | either "." for installation from |
-| | local sources, "apache-airflow" |
-| | for installation from packages |
-| | and URL to installation from |
-| | GitHub repository (see below) |
-| | to install from any GitHub |
-| | version |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_INSTALL_VERSION`` | Optional - might be used for |
-| | package installation case to |
-| | set Airflow version for example |
-| | "==1.10.14". Remember to also |
-| | Set ``AIRFLOW_VERSION`` |
-| | when you use it. |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_CONSTRAINTS_REFERENCE`` | reference (branch or tag) from |
-| | GitHub where constraints file |
-| | is taken from. By default it is |
-| | ``constraints-master`` but can be |
-| | ``constraints-1-10`` for 1.10.* |
-| | constraint or if you want to |
-| | point to specific version |
-| | might be ``constraints-1.10.14`` |
-+-----------------------------------+-----------------------------------+
-| ``SLUGIFY_USES_TEXT_UNIDECODE`` | In case of of installing airflow |
-| | 1.10.2 or 1.10.1 you need to |
-| | set this arg to ``yes``. |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_WWW`` | In case of Airflow 2.0 it should |
-| | be "www", in case of Airflow 1.10 |
-| | series it should be "www_rbac". |
-| | See examples below |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_SOURCES_FROM`` | Sources of Airflow. Set it to |
-| | "empty" to avoid costly |
-| | Docker context copying |
-| | in case of installation from |
-| | the package or from GitHub URL. |
-| | See examples below |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_SOURCES_TO`` | Target for Airflow sources. Set |
-| | to "/empty" to avoid costly |
-| | Docker context copying |
-| | in case of installation from |
-| | the package or from GitHub URL. |
-| | See examples below |
-+-----------------------------------+-----------------------------------+
-
++-----------------------------------+------------------------+-----------------------------------------------------------------------------------+
+| Build argument | Default | What to specify |
++===================================+========================+===================================================================================+
+| ``AIRFLOW_INSTALLATION_MEDIA`` | ``apache-airflow`` | Should point to the installation media of Apache Airflow. It can "apache-airflow" |
Review comment:
All looks good, except the name of this var `AIRFLOW_INSTALLATION_MEDIA` , should we `AIRFLOW_PACKAGE` / `AIRFLOW_COMPONENT` or any other suggestion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org