You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/05/29 20:20:18 UTC
Review Request 67362: Updated `linux/devices` isolator tests for
compiler compatibility.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67362/
-----------------------------------------------------------
Review request for mesos and Alexander Rukletsov.
Repository: mesos
Description
-------
The `linux/devices` isolator tests fail to build on on
Ubuntu 14.04 with `gcc (Ubuntu 4.8.4-2ubuntu1~14.04.4)
4.8.4` due to what seems to me a compiler bug, possibly
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57824.
Work around any compiler issues by defining the test cases
in a separate vector so that the copmiler doesn't have any
raw strings in the macro expansion.
Diffs
-----
src/tests/containerizer/linux_devices_isolator_tests.cpp efaa43b8b7b7c73c35d995bfbb81fcd620143ea1
Diff: https://reviews.apache.org/r/67362/diff/1/
Testing
-------
sudo make check (Fedora 27)
Thanks,
James Peach
Re: Review Request 67362: Updated `linux/devices` isolator tests for
compiler compatibility.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67362/#review204013
-----------------------------------------------------------
PASS: Mesos patch 67362 was successfully built and tested.
Reviews applied: `['67362']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67362
- Mesos Reviewbot Windows
On May 29, 2018, 8:20 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67362/
> -----------------------------------------------------------
>
> (Updated May 29, 2018, 8:20 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jie Yu.
>
>
> Bugs: MESOS-8958
> https://issues.apache.org/jira/browse/MESOS-8958
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `linux/devices` isolator tests fail to build on on
> Ubuntu 14.04 with `gcc (Ubuntu 4.8.4-2ubuntu1~14.04.4)
> 4.8.4` due to what seems to me a compiler bug, possibly
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57824.
>
> Work around any compiler issues by defining the test cases
> in a separate vector so that the copmiler doesn't have any
> raw strings in the macro expansion.
>
>
> Diffs
> -----
>
> src/tests/containerizer/linux_devices_isolator_tests.cpp efaa43b8b7b7c73c35d995bfbb81fcd620143ea1
>
>
> Diff: https://reviews.apache.org/r/67362/diff/2/
>
>
> Testing
> -------
>
> sudo make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67362: Updated `linux/devices` isolator tests for
compiler compatibility.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67362/#review204011
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On May 29, 2018, 8:20 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67362/
> -----------------------------------------------------------
>
> (Updated May 29, 2018, 8:20 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jie Yu.
>
>
> Bugs: MESOS-8958
> https://issues.apache.org/jira/browse/MESOS-8958
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `linux/devices` isolator tests fail to build on on
> Ubuntu 14.04 with `gcc (Ubuntu 4.8.4-2ubuntu1~14.04.4)
> 4.8.4` due to what seems to me a compiler bug, possibly
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57824.
>
> Work around any compiler issues by defining the test cases
> in a separate vector so that the copmiler doesn't have any
> raw strings in the macro expansion.
>
>
> Diffs
> -----
>
> src/tests/containerizer/linux_devices_isolator_tests.cpp efaa43b8b7b7c73c35d995bfbb81fcd620143ea1
>
>
> Diff: https://reviews.apache.org/r/67362/diff/2/
>
>
> Testing
> -------
>
> sudo make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>