You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Konstantin Boudnik (JIRA)" <ji...@apache.org> on 2011/04/28 20:12:03 UTC
[jira] [Created] (HADOOP-7248) Have a way to automatically update
Eclipse .classpath file when new libs are added to the classpath through
Ivy for 0.20-* based sources
Have a way to automatically update Eclipse .classpath file when new libs are added to the classpath through Ivy for 0.20-* based sources
----------------------------------------------------------------------------------------------------------------------------------------
Key: HADOOP-7248
URL: https://issues.apache.org/jira/browse/HADOOP-7248
Project: Hadoop Common
Issue Type: Improvement
Components: build
Affects Versions: 0.21.0, 0.22.0
Reporter: Konstantin Boudnik
Assignee: Tom White
Priority: Minor
Fix For: 0.21.0
Currently Eclipse configuration (namely .classpath) isn't synchronized automatically when lib versions are changed. This causes great inconvenience so people have to change their project settings manually, etc.
It'd be great if these configs could be updated automatically every time such a change takes place, e.g. whenever ivy is pulling in new version of a jar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7248) Have a way to automatically update
Eclipse .classpath file when new libs are added to the classpath through
Ivy for 0.20-* based sources
Posted by "Thomas Graves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030004#comment-13030004 ]
Thomas Graves commented on HADOOP-7248:
---------------------------------------
build failed because patch is for branch-0.20-security not trunk.
> Have a way to automatically update Eclipse .classpath file when new libs are added to the classpath through Ivy for 0.20-* based sources
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7248
> URL: https://issues.apache.org/jira/browse/HADOOP-7248
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.20.3
> Reporter: Konstantin Boudnik
> Assignee: Thomas Graves
> Priority: Minor
> Fix For: 0.20.205.0
>
> Attachments: HADOOP-7248-branch-20-security.patch
>
>
> Backport HADOOP-6407 into 0.20 based source trees
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7248) Have a way to automatically update
Eclipse .classpath file when new libs are added to the classpath through
Ivy for 0.20-* based sources
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-7248:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I took a closer look at the patch, and came across this section:
{noformat}
+ <condition property="ant-eclipse.jar.exists">
+ <available file="${build.dir}/lib/ant-eclipse-1.0-jvm1.2.jar"/>
+ </condition>
+
+ <target name="ant-eclipse-download" unless="ant-eclipse.jar.exists"
+ description="Downloads the ant-eclipse binary.">
+ <get src="http://downloads.sourceforge.net/project/ant-eclipse/ant-eclipse/1.0/ant-eclipse-1.0.bin.tar.bz2"
+ dest="${build.dir}/ant-eclipse-1.0.bin.tar.bz2" usetimestamp="false" />
+
+ <untar src="${build.dir}/ant-eclipse-1.0.bin.tar.bz2"
+ dest="${build.dir}" compression="bzip2">
+ <patternset>
+ <include name="lib/ant-eclipse-1.0-jvm1.2.jar"/>
+ </patternset>
+ </untar>
+ <delete file="${build.dir}/ant-eclipse-1.0.bin.tar.bz2" />
+ </target>
{noformat}
Installing this jar into the maven cache would not only avoid downloading it so often, but it would also make the eclipse target valid when building offline. However, it looks like HADOOP-6407 (and related issues) made the same choice, so this can be a separate issue.
I committed this to the 20-security branch.
> Have a way to automatically update Eclipse .classpath file when new libs are added to the classpath through Ivy for 0.20-* based sources
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7248
> URL: https://issues.apache.org/jira/browse/HADOOP-7248
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.20.3
> Reporter: Konstantin Boudnik
> Assignee: Thomas Graves
> Priority: Minor
> Fix For: 0.20.205.0
>
> Attachments: C7248-1.patch, HADOOP-7248-branch-20-security.patch
>
>
> Backport HADOOP-6407 into 0.20 based source trees
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7248) Have a way to automatically update
Eclipse .classpath file when new libs are added to the classpath through
Ivy for 0.20-* based sources
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-7248:
----------------------------------
Attachment: C7248-1.patch
This section:
{noformat}
+ <source path="${test.src.dir}/mapred"
+ output="${build.dir.eclipse-test-classes}" />
{noformat}
Didn't work on git, because the src/test/mapred dirs are empty in subversion. I deleted this tree from SVN and updated the patch.
+1 Otherwise. Applied this to a fresh checkout, ran the new target, and all was good.
> Have a way to automatically update Eclipse .classpath file when new libs are added to the classpath through Ivy for 0.20-* based sources
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7248
> URL: https://issues.apache.org/jira/browse/HADOOP-7248
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.20.3
> Reporter: Konstantin Boudnik
> Assignee: Thomas Graves
> Priority: Minor
> Fix For: 0.20.205.0
>
> Attachments: C7248-1.patch, HADOOP-7248-branch-20-security.patch
>
>
> Backport HADOOP-6407 into 0.20 based source trees
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7248) Have a way to automatically update
Eclipse .classpath file when new libs are added to the classpath through
Ivy for 0.20-* based sources
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-7248:
---------------------------------------
Description: Backport HADOOP-7240 into 0.20 based source trees (was: Currently Eclipse configuration (namely .classpath) isn't synchronized automatically when lib versions are changed. This causes great inconvenience so people have to change their project settings manually, etc.
It'd be great if these configs could be updated automatically every time such a change takes place, e.g. whenever ivy is pulling in new version of a jar. )
Affects Version/s: (was: 0.22.0)
(was: 0.21.0)
0.20.3
Assignee: (was: Tom White)
Hadoop Flags: (was: [Reviewed])
> Have a way to automatically update Eclipse .classpath file when new libs are added to the classpath through Ivy for 0.20-* based sources
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7248
> URL: https://issues.apache.org/jira/browse/HADOOP-7248
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.20.3
> Reporter: Konstantin Boudnik
> Priority: Minor
> Fix For: 0.21.0
>
>
> Backport HADOOP-7240 into 0.20 based source trees
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HADOOP-7248) Have a way to automatically update
Eclipse .classpath file when new libs are added to the classpath through
Ivy for 0.20-* based sources
Posted by "Thomas Graves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Graves reassigned HADOOP-7248:
-------------------------------------
Assignee: Thomas Graves
> Have a way to automatically update Eclipse .classpath file when new libs are added to the classpath through Ivy for 0.20-* based sources
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7248
> URL: https://issues.apache.org/jira/browse/HADOOP-7248
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.20.3
> Reporter: Konstantin Boudnik
> Assignee: Thomas Graves
> Priority: Minor
> Fix For: 0.21.0
>
>
> Backport HADOOP-6407 into 0.20 based source trees
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7248) Have a way to automatically update
Eclipse .classpath file when new libs are added to the classpath through
Ivy for 0.20-* based sources
Posted by "Thomas Graves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029999#comment-13029999 ]
Thomas Graves commented on HADOOP-7248:
---------------------------------------
[exec] -1 overall.
[exec] [exec] +1 @author. The patch does not contain any @author tags.
[exec] [exec] +1 tests included. The patch appears to include 19 new or modified tests.
[exec] [exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages.
[exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec] [exec] -1 Eclipse classpath. The patch causes the Eclipse classpath to differ from the contents of the lib directories.
[exec]
The javadoc and eclipse classpath were failing before this patch. Once this is commited the eclipse classpath check should start showing +1 again.
I manually tested this:
- check out svn tree
- apply patch
- svn rm the empty files
- build eclipse target either from within eclipse or with ant eclipse
- refresh eclipse
- build eclipse project
- everything resolves and you can run unit tests
> Have a way to automatically update Eclipse .classpath file when new libs are added to the classpath through Ivy for 0.20-* based sources
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7248
> URL: https://issues.apache.org/jira/browse/HADOOP-7248
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.20.3
> Reporter: Konstantin Boudnik
> Assignee: Thomas Graves
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: HADOOP-7248-branch-20-security.patch
>
>
> Backport HADOOP-6407 into 0.20 based source trees
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7248) Have a way to automatically update
Eclipse .classpath file when new libs are added to the classpath through
Ivy for 0.20-* based sources
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-7248:
---------------------------------------
Description: Backport HADOOP-6407 into 0.20 based source trees (was: Backport HADOOP-7240 into 0.20 based source trees)
> Have a way to automatically update Eclipse .classpath file when new libs are added to the classpath through Ivy for 0.20-* based sources
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7248
> URL: https://issues.apache.org/jira/browse/HADOOP-7248
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.20.3
> Reporter: Konstantin Boudnik
> Priority: Minor
> Fix For: 0.21.0
>
>
> Backport HADOOP-6407 into 0.20 based source trees
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7248) Have a way to automatically update
Eclipse .classpath file when new libs are added to the classpath through
Ivy for 0.20-* based sources
Posted by "Thomas Graves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Graves updated HADOOP-7248:
----------------------------------
Attachment: HADOOP-7248-branch-20-security.patch
patch for branch-0.20-security
> Have a way to automatically update Eclipse .classpath file when new libs are added to the classpath through Ivy for 0.20-* based sources
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7248
> URL: https://issues.apache.org/jira/browse/HADOOP-7248
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.20.3
> Reporter: Konstantin Boudnik
> Assignee: Thomas Graves
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: HADOOP-7248-branch-20-security.patch
>
>
> Backport HADOOP-6407 into 0.20 based source trees
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7248) Have a way to automatically update
Eclipse .classpath file when new libs are added to the classpath through
Ivy for 0.20-* based sources
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-7248:
----------------------------------
Fix Version/s: 0.20.204.0
> Have a way to automatically update Eclipse .classpath file when new libs are added to the classpath through Ivy for 0.20-* based sources
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7248
> URL: https://issues.apache.org/jira/browse/HADOOP-7248
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.20.3
> Reporter: Konstantin Boudnik
> Assignee: Thomas Graves
> Priority: Minor
> Fix For: 0.20.204.0, 0.20.205.0
>
> Attachments: C7248-1.patch, HADOOP-7248-branch-20-security.patch
>
>
> Backport HADOOP-6407 into 0.20 based source trees
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7248) Have a way to automatically update
Eclipse .classpath file when new libs are added to the classpath through
Ivy for 0.20-* based sources
Posted by "Thomas Graves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Graves updated HADOOP-7248:
----------------------------------
Fix Version/s: (was: 0.21.0)
0.20.205.0
Status: Patch Available (was: Open)
> Have a way to automatically update Eclipse .classpath file when new libs are added to the classpath through Ivy for 0.20-* based sources
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7248
> URL: https://issues.apache.org/jira/browse/HADOOP-7248
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.20.3
> Reporter: Konstantin Boudnik
> Assignee: Thomas Graves
> Priority: Minor
> Fix For: 0.20.205.0
>
> Attachments: HADOOP-7248-branch-20-security.patch
>
>
> Backport HADOOP-6407 into 0.20 based source trees
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7248) Have a way to automatically update
Eclipse .classpath file when new libs are added to the classpath through
Ivy for 0.20-* based sources
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030003#comment-13030003 ]
Hadoop QA commented on HADOOP-7248:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12478446/HADOOP-7248-branch-20-security.patch
against trunk revision 1100113.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 19 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/415//console
This message is automatically generated.
> Have a way to automatically update Eclipse .classpath file when new libs are added to the classpath through Ivy for 0.20-* based sources
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7248
> URL: https://issues.apache.org/jira/browse/HADOOP-7248
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.20.3
> Reporter: Konstantin Boudnik
> Assignee: Thomas Graves
> Priority: Minor
> Fix For: 0.20.205.0
>
> Attachments: HADOOP-7248-branch-20-security.patch
>
>
> Backport HADOOP-6407 into 0.20 based source trees
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7248) Have a way to automatically update
Eclipse .classpath file when new libs are added to the classpath through
Ivy for 0.20-* based sources
Posted by "Thomas Graves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029367#comment-13029367 ]
Thomas Graves commented on HADOOP-7248:
---------------------------------------
I've backported this change to the branch-0.20-security. I'm facing an issue in running the unit tests in eclipse where it can't find the webapps directory now. I see there was a jira https://issues.apache.org/jira/browse/HADOOP-6461 that went into 22 that worked around the issue. I'm looking for feedback if people think that is the proper thing to do or if I should have the build.xml copy it into the eclipse classpath or something else? I'm new to hadoop so am not familiar with all the use cases and processes yet.
Also does anyone know if all the tests in the 20 branch were running via eclipse?
> Have a way to automatically update Eclipse .classpath file when new libs are added to the classpath through Ivy for 0.20-* based sources
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7248
> URL: https://issues.apache.org/jira/browse/HADOOP-7248
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.20.3
> Reporter: Konstantin Boudnik
> Priority: Minor
> Fix For: 0.21.0
>
>
> Backport HADOOP-6407 into 0.20 based source trees
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7248) Have a way to automatically update
Eclipse .classpath file when new libs are added to the classpath through
Ivy for 0.20-* based sources
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031408#comment-13031408 ]
Hadoop QA commented on HADOOP-7248:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12478740/C7248-1.patch
against trunk revision 1101653.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 19 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/424//console
This message is automatically generated.
> Have a way to automatically update Eclipse .classpath file when new libs are added to the classpath through Ivy for 0.20-* based sources
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7248
> URL: https://issues.apache.org/jira/browse/HADOOP-7248
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.20.3
> Reporter: Konstantin Boudnik
> Assignee: Thomas Graves
> Priority: Minor
> Fix For: 0.20.205.0
>
> Attachments: C7248-1.patch, HADOOP-7248-branch-20-security.patch
>
>
> Backport HADOOP-6407 into 0.20 based source trees
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7248) Have a way to automatically update
Eclipse .classpath file when new libs are added to the classpath through
Ivy for 0.20-* based sources
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-7248:
----------------------------------
Fix Version/s: (was: 0.20.205.0)
> Have a way to automatically update Eclipse .classpath file when new libs are added to the classpath through Ivy for 0.20-* based sources
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7248
> URL: https://issues.apache.org/jira/browse/HADOOP-7248
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.20.3
> Reporter: Konstantin Boudnik
> Assignee: Thomas Graves
> Priority: Minor
> Fix For: 0.20.204.0
>
> Attachments: C7248-1.patch, HADOOP-7248-branch-20-security.patch
>
>
> Backport HADOOP-6407 into 0.20 based source trees
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira