[GitHub] [geode] upthewaterspout opened pull request #3145: GEODE-6348: Wait for cache to close in test of ConflictingPersistentData

["upthewaterspout (GitHub)" <gi...@apache.org>]

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3145 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] onichols-pivotal commented on pull request #3145: GEODE-6348: Wait for cache to close in test of ConflictingPersistentData

["onichols-pivotal (GitHub)" <gi...@apache.org>]

Makes sense that the test wants to wait for cache to be completely closed.  However, why can't that be done by Geode as part of raising the ConflictingPersistentDataException?  Otherwise I can imagine that all other code that can potentially catch this exception should also be modified to wait for cache to close fully...?

[ Full content available at: https://github.com/apache/geode/pull/3145 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] upthewaterspout commented on pull request #3145: GEODE-6348: Wait for cache to close in test of ConflictingPersistentData

["upthewaterspout (GitHub)" <gi...@apache.org>]

I think that is a good idea ... but it's a little tricky to implement. The place where we throw these exceptions is holding locks that would prevent closing the cache - so we would need to through the exception and then handle it higher up in all of the APIs that could trigger a this exception.

Practically speaking I think users won't be handling these exceptions - they will occur as part of starting up the cache server process. That process will exit as soon as the cache is closed.

[ Full content available at: https://github.com/apache/geode/pull/3145 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] upthewaterspout closed pull request #3145: GEODE-6348: Wait for cache to close in test of ConflictingPersistentData

["upthewaterspout (GitHub)" <gi...@apache.org>]

[ pull request closed by upthewaterspout ]

[ Full content available at: https://github.com/apache/geode/pull/3145 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org