You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/10/14 01:10:19 UTC

[GitHub] [phoenix] yanxinyi commented on a change in pull request #1330: PHOENIX-6572 Add Metrics for SystemCatalog Table

yanxinyi commented on a change in pull request #1330:
URL: https://github.com/apache/phoenix/pull/1330#discussion_r728554133



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -1793,9 +1811,19 @@ private MetaDataMutationResult metaDataCoprocessorExec(byte[] tableKey,
                         retried = true;
                         continue;
                     }
+                    success = true;
                     return MetaDataMutationResult.constructFromProto(result);
                 } finally {
-                    Closeables.closeQuietly(ht);

Review comment:
       will add this closeQuietly back




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org