[GitHub] [airflow] blag commented on pull request #23335: Unify approach for user questions asked in Breeze

[GitBox <gi...@apache.org>]

blag commented on PR #23335:
URL: https://github.com/apache/airflow/pull/23335#issuecomment-1112568162

   What is the rationale behind making timeout values be single digit seconds?
   
   For somebody who _knows_ a priori what the questions are going to be and the implications of their answers are, they can probably predict or at least quickly recognize what the text is saying and respond that quickly. But for anybody who needs extra time to read things (hint: people with reading difficulties and/or disabilities), for newbies who need to read and make a decision, or for people who just like to read what their computer is saying to them (which is a practice that we should support!), single digit timeouts are far too short, in an extreme way.
   
   I'm not a fan of timeouts, period. If somebody is important enough to display to the user and request the user's input on, it's important enough to require the user's input. Otherwise we should just emit a warning and carry on.
   
   But on top of that, forcing default answers if the user doesn't answer within a timeout is also something that should not be standard practice, and should not be commonly done. Asking the user for input, and then ignoring their lack of input is tantamount to just guessing at their intent. And the Zen of Python has something to say about that: ["In the face of ambiguity, refuse the temptation to guess."](https://peps.python.org/pep-0020/)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org