[jira] [Commented] (HBASE-14256) Flush task message may be confusing when region is recovered

["Gabor Liptak (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956137#comment-14956137 ] 

Gabor Liptak commented on HBASE-14256:
--------------------------------------

The compile failure seems unrelated.

> Flush task message may be confusing when region is recovered
> ------------------------------------------------------------
>
>                 Key: HBASE-14256
>                 URL: https://issues.apache.org/jira/browse/HBASE-14256
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 2.0.0, 1.2.0
>            Reporter: Lars George
>            Assignee: Gabor Liptak
>              Labels: beginner
>         Attachments: HBASE-14256.1.patch
>
>
> In {{HRegion.setRecovering()}} we have this code:
> {code}
>     // force a flush only if region replication is set up for this region. Otherwise no need.
>       boolean forceFlush = getTableDesc().getRegionReplication() > 1;
>       // force a flush first
>       MonitoredTask status = TaskMonitor.get().createStatus(
>         "Flushing region " + this + " because recovery is finished");
>       try {
>         if (forceFlush) {
>           internalFlushcache(status);
>         }
> {code}
> So we only optionally force flush after a recovery of a region, but the message always is set to "Flushing...", which might be confusing. We should change the message based on {{forceFlush}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)