You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/12/07 04:19:55 UTC

Review Request 54467: Fixed incorrect warning messages.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54467/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos


Description
-------

These warning messages printed the old value of the `FrameworkInfo`
field, not the new (ignored) value.


Diffs
-----

  src/master/master.hpp b444b2352360fb4f7179acd97dffc0cd81cc7afa 

Diff: https://reviews.apache.org/r/54467/diff/


Testing
-------

`make check`


Thanks,

Neil Conway

Re: Review Request 54467: Fixed incorrect warning messages.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54467/#review158461
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Dec. 7, 2016, 4:19 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54467/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 4:19 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These warning messages printed the old value of the `FrameworkInfo`
> field, not the new (ignored) value.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp b444b2352360fb4f7179acd97dffc0cd81cc7afa 
> 
> Diff: https://reviews.apache.org/r/54467/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>